Estimate contig lengths in SequenceDictionary for BED, GFF3, GTF, and NarrowPeak feature formats #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… NarrowPeak feature formats
1 similar comment
|
Test PASSed. |
fnothaft
requested changes
Mar 2, 2017
| // create sequence records with length max(start, end) + 1L | ||
| val sequenceRecords = rdd | ||
| .keyBy(_.getContigName) | ||
| .map(kv => (kv._1, Math.max(kv._2.getStart, kv._2.getEnd) + 1L)) |
There was a problem hiding this comment.
Small preference, but I'd rather import scala.math.max and change Math.max -> max.
| val sequenceRecords = rdd | ||
| .keyBy(_.getContigName) | ||
| .map(kv => (kv._1, Math.max(kv._2.getStart, kv._2.getEnd) + 1L)) | ||
| .reduceByKey(math.max(_, _)) |
There was a problem hiding this comment.
Same here math.max(_, _) -> max
|
Test PASSed. |
fnothaft
approved these changes
Mar 3, 2017
|
Merged! Thanks @heuermh! |
This was referenced Mar 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #1378 for easier review and merge. Fixes #1409, fixes #1410.