[ADAM-1164] Add parallel file merger. #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
|
Just following up with runtime numbers. With this, saving the NA12878 234GB BAM back to a single BAM from Parquet runs in 4.4 minutes on 833 cores (2.4 minutes to go ADAM->BAM, 2.0 minutes to do the merge). Without this, it takes 44 minutes (2.3 minutes to go ADAM->BAM, the remainder to merge). |
heuermh
approved these changes
Mar 20, 2017
| // | ||
| // ideally, this would be a directory, however, fs.concat has the | ||
| // undocumented contract that the paths being merged must live in | ||
| // the same directory as the path they are being merged to |
There was a problem hiding this comment.
what? hope you didn't have to find that out the hard way
| // UNDOCUMENTED in hadoop fs API: | ||
| // all paths passed to the concat method must be qualified with | ||
| // full scheme and name node URI | ||
| val outputPaths = (0 until numBlocksToWrite).map(idx => { |
|
Thank you, @fnothaft! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1164. I'd actually love to get this into 0.22.0 as well. Thoughts?