Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1476] Treat . ALT allele as symbolic non-ref. #1477

Merged
merged 1 commit into from
Apr 7, 2017

Conversation

fnothaft
Copy link
Member

@fnothaft fnothaft commented Apr 6, 2017

Resolves #1476.

@coveralls
Copy link

coveralls commented Apr 6, 2017

Coverage Status

Coverage increased (+0.1%) to 81.637% when pulling b20dce2 on fnothaft:issues/1476-drop-.-alts into 9505d47 on bigdatagenomics:master.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1935/
Test PASSed.

@@ -182,31 +182,37 @@ class ADAMContextSuite extends ADAMFunSuite {
sparkTest("can read a gzipped .vcf file") {
val path = testFile("test.vcf.gz")
val vcs = sc.loadVcf(path)
assert(vcs.rdd.count === 6)
assert(vcs.rdd.count === 7)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

were the compressed test resources changed too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope... they appear to have been a compressed version of the VCF file from Hadoop-BAM.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@heuermh heuermh merged commit 93b32c6 into bigdatagenomics:master Apr 7, 2017
@heuermh
Copy link
Member

heuermh commented Apr 7, 2017

Thank you, @fnothaft!

@a1xt06
Copy link

a1xt06 commented Apr 7, 2017

Thank you!

@heuermh heuermh added this to the 0.23.0 milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants