Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADAM-1483] Remove collapse parameter from AlignmentRecordRDD.toCoverage #1493

Merged
merged 1 commit into from
May 10, 2017
Merged

[ADAM-1483] Remove collapse parameter from AlignmentRecordRDD.toCoverage #1493

merged 1 commit into from
May 10, 2017

Conversation

fnothaft
Copy link
Member

Resolves #1483. Instead of providing a parameter in the toCoverage method to allow users to collapse the coverage, makes the toCoverage method stupid. This makes the toCoverage method simpler and the behavior easier to reason about.

@fnothaft fnothaft added this to the 0.23.0 milestone Apr 17, 2017
@coveralls
Copy link

coveralls commented Apr 17, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.05%) to 81.668% when pulling 82c982e on fnothaft:issues/1483-reads-coverage-collapse into 04444aa on bigdatagenomics:master.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1951/
Test PASSed.

@heuermh
Copy link
Member

heuermh commented May 3, 2017

Ping @akmorrow13 for review

@fnothaft
[ADAM-1483] Remove collapse parameter from AlignmentRecordRDD.toCoverage
04c5764 
Resolves bigdatagenomics#1483. Instead of providing a parameter in the `toCoverage` method to
allow users to collapse the coverage, makes the `toCoverage` method stupid. This
makes the `toCoverage` method simpler and the behavior easier to reason about.
@fnothaft fnothaft force-pushed the issues/1483-reads-coverage-collapse branch from 82c982e to 04c5764 Compare May 10, 2017 19:17
@fnothaft
Copy link
Member Author

@heuermh Rebased.

@coveralls
Copy link

coveralls commented May 10, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.09%) to 81.873% when pulling 04c5764 on fnothaft:issues/1483-reads-coverage-collapse into 4eea07c on bigdatagenomics:master.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1981/
Test PASSed.

@heuermh heuermh merged commit ea9ce6c into bigdatagenomics:master May 10, 2017
@heuermh
Copy link
Member

heuermh commented May 10, 2017

Thank you, @fnothaft!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heuermh heuermh heuermh approved these changes

@akmorrow13 akmorrow13 Awaiting requested review from akmorrow13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@fnothaft @coveralls @AmplabJenkins @heuermh