Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADAM-1579] Add unit test coverage for BED12 format. #1587

Merged
merged 1 commit into from
Jul 5, 2017
Merged

[ADAM-1579] Add unit test coverage for BED12 format. #1587

merged 1 commit into from
Jul 5, 2017

Conversation

fnothaft
Copy link
Member

@fnothaft fnothaft commented Jul 4, 2017

Resolves #1579. Found small bugs that would lead to last 6 fields not getting written if the thickStart field wasn't written. Also, identified a bug where the strand would be set to unknown if an independent strand was provided.

@fnothaft
[ADAM-1579] Add unit test coverage for BED12 format.
ee331a2 
Resolves bigdatagenomics#1579. Found small bugs that would lead to last 6 fields not getting
written if the thickStart field wasn't written. Also, identified a bug where the
strand would be set to unknown if an independent strand was provided.
@fnothaft fnothaft requested a review from heuermh July 4, 2017 22:18
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 82.744% when pulling ee331a2 on fnothaft:issues/1579-bed12-unittest into 0306717 on bigdatagenomics:master.

@coveralls
Copy link

coveralls commented Jul 4, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 83.267% when pulling ee331a2 on fnothaft:issues/1579-bed12-unittest into 0306717 on bigdatagenomics:master.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2174/
Test PASSed.

heuermh
heuermh approved these changes Jul 5, 2017
View reviewed changes
Copy link
Member

@heuermh heuermh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@heuermh heuermh merged commit 9ff0387 into bigdatagenomics:master Jul 5, 2017
@heuermh
Copy link
Member

heuermh commented Jul 5, 2017

Thank you, @fnothaft

@fnothaft fnothaft deleted the issues/1579-bed12-unittest branch July 5, 2017 17:57
@heuermh heuermh added this to the 0.23.0 milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heuermh heuermh heuermh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@fnothaft @coveralls @AmplabJenkins @heuermh