Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added switches to spark context creation code #161

Merged
merged 1 commit into from
Mar 3, 2014

Conversation

fnothaft
Copy link
Member

@fnothaft fnothaft commented Mar 3, 2014

Adds the following switches to the spark context creation code:

  • A switch to allow for configuring the size of the Spark Kryo buffer. This is necessary for indel realignment on larger datasets.
  • A switch to add a logger that prints debug text after every stage. This debug text contains information about data movement inside of the command that is being run, and is useful for performance analysis/profiling.

This addresses #149.

@tdanford
Copy link
Contributor

tdanford commented Mar 3, 2014

Jenkins, test this please.

@tdanford
Copy link
Contributor

tdanford commented Mar 3, 2014

Awww, Jenkins doesn't like me :-(

@fnothaft
Copy link
Member Author

fnothaft commented Mar 3, 2014

Jenkins, test this please.

@tdanford I think there is a list of Jenkins admins who Jenkins will look for comments from. I'm not sure about this though; @jey/@massie?

@tdanford
Copy link
Contributor

tdanford commented Mar 3, 2014

I thought matt had added us to that list? Maybe I'm hallucinating, or am
mis-remembering an old email.

On Mon, Mar 3, 2014 at 1:20 PM, Frank Austin Nothaft <
notifications@github.com> wrote:

Jenkins, test this please.

@tdanford https://github.com/tdanford I think there is a list of
Jenkins admins who Jenkins will look for comments from. I'm not sure about
this though; @jey/@massie https://github.com/massie?


Reply to this email directly or view it on GitHubhttps://github.com//pull/161#issuecomment-36540174
.

@carlyeks
Copy link
Member

carlyeks commented Mar 3, 2014

Yeah, I think this may be some deeper issue; Jenkins should have tested this anyway since it was from someone who should be whitelisted...

@fnothaft
Copy link
Member Author

fnothaft commented Mar 3, 2014

@tdanford if it's any consolation, @AmplabJenkins doesn't seem to be listening to me either. I think our faithful butler has shown up to work drunk today.

@tdanford
Copy link
Contributor

tdanford commented Mar 3, 2014

Noooo, don't do it Jenkins! :-)

@tdanford
Copy link
Contributor

tdanford commented Mar 3, 2014

Frank, can you add a comment about this in the CHANGES file(s)?

@fnothaft
Copy link
Member Author

fnothaft commented Mar 3, 2014

I'm holding on that, pending the resolution of the current email thread. If we stick with the CHANGES.md file, that file shouldn't be hand edited anyways.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/193/

@carlyeks
Copy link
Member

carlyeks commented Mar 3, 2014

Can you include an update to the changes document? Otherwise, this looks ready to merge.

@fnothaft
Copy link
Member Author

fnothaft commented Mar 3, 2014

@carlyeks CHANGES files are updated.

tdanford added a commit that referenced this pull request Mar 3, 2014
Added switches to spark context creation code
@tdanford tdanford merged commit 6fdf373 into bigdatagenomics:master Mar 3, 2014
@tdanford
Copy link
Contributor

tdanford commented Mar 3, 2014

Thanks, Frank!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants