[ADAM-1615] Add transform and transmute APIs to Java, R, and Python #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
| } | ||
| import org.bdgenomics.adam.sql._ | ||
| import scala.reflect.runtime.universe._ | ||
| import scala.reflect.runtime.universe.TypeTag |
There was a problem hiding this comment.
Can this line be removed?
There was a problem hiding this comment.
Ah yeah, it should be removed.
There was a problem hiding this comment.
There are a few more instances of this in this PR.
| @@ -42,6 +42,8 @@ import org.bdgenomics.utils.interval.array.{ | |||
| import scala.collection.JavaConversions._ | |||
| import scala.math.max | |||
| import scala.reflect.ClassTag | |||
| import scala.reflect.runtime.universe._ | |||
| import scala.reflect.runtime.universe.TypeTag | |||
There was a problem hiding this comment.
This line can be removed also.
heuermh
approved these changes
Jul 25, 2017
| dfFn = self._wrapTransformation(tFn) | ||
|
|
||
| # if no conversion function is provided, try to infer | ||
| if convFn is None: |
There was a problem hiding this comment.
This method name stuff is brittle, but I can't see any other way to do it
Resolves bigdatagenomics#1615. Adds `GenomicDatasetConversion` class to adam-core API, along with accompanying implementations in `org.bdgenomics.adam.api.java` package. Adds `transformDataFrame` and `transmuteDataFrame` to `GenomicRDD` API. To enable use from Python and R, we provide a `DataFrameConversionWrapper` that wraps the product of an R/Python function in a Spark Java API `Function`.
fnothaft
force-pushed
the
issues/1615-transform-transmute-java-r-python
branch
from
b5b9a5f
to
6778abd
Compare
|
Test PASSed. |
|
Thank you, @fnothaft! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1615. Adds
GenomicDatasetConversionclass to adam-core API, along with accompanying implementations inorg.bdgenomics.adam.api.javapackage. AddstransformDataFrameandtransmuteDataFrametoGenomicRDDAPI. To enable use from Python and R, we provide aDataFrameConversionWrapperthat wraps the product of an R/Python function in a Spark Java APIFunction.GenomicDataset.