Pair-wise genotype concordance of genotype RDDs, with CLI tool #166
Conversation
|
Can one of the admins verify this patch? |
|
|
||
|
|
||
| class ADAMGenotypeRDDFunctionsSuite extends SparkFunSuite { | ||
| val tempDir = Files.createTempDir() |
|
Thanks for the helpful comments. Pushed suggest changes to test code. |
|
Jenkins, add to whitelist and test this please. |
| sampleId, | ||
| alleles | ||
| = SchemaValue | ||
| } |
There was a problem hiding this comment.
Git would like to see a newline at the end of this file.
It seems that this enumeration doesn't fully cover the fields in ADAMGenotype; if we are adding this, let's cover all the fields.
|
All automated tests passed. |
Address review comments on Concordance pull request Address review comments on Concordance pull request
|
@mlinderm Would you like this merged? |
|
Updated (and squashed…) based on Frank's comments |
Pair-wise genotype concordance of genotype RDDs, with CLI tool
|
Thanks @mlinderm! Merged. |
|
For future reference, how do I do the nifty automated testing? |
|
"Jenkins, test this please." is the key phrase, but it should kick off automatically... |
|
Jenkins, test this please |
|
resolve #84 |
|
Michael, I just added you to the list of Jenkins admins so that you can issue command to it (him?). When a new pull request is opened in the project and the author of the pull request isn't white-listed, builder will ask "Can one of the admins verify this patch?".
If the build fails for other various reasons you can rebuild. "retest this please" to start a new build |
Basic pair-wise genotype concordance tool.