-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove python and R profiles from release script #1842
Conversation
Test PASSed. |
The more I play with this, the less likely I think it will work.
I know we wanted to add the python egg #1667 and R tarball #1668 to the release distribution tarball, I'm not seeing how to make that work in a single maven call (i.e. the inner call to maven on the checked out release tag). In fact, it is not currently working for snapshots uploaded by Jenkins. $ wget https://oss.sonatype.org/content/repositories/snapshots/org/bdgenomics/adam/adam-distribution-spark2_2.11/0.23.0-SNAPSHOT/adam-distribution-spark2_2.11-0.23.0-20171221.152447-595-bin.tar.gz
$ tar xvfz adam-distribution-spark2_2.11-0.23.0-20171221.152447-595-bin.tar.gz
$ cd adam-distribution-spark2_2.11-0.23.0-SNAPSHOT
$ ls | cat
CHANGES.md
CONTRIBUTING.md
LICENSE.txt
README.md
bin
javadocs
repo
scaladocs
$ find . -name "*.tar.gz"
$ find . -name "*.egg" I'm thinking we may need to remove Ping @fnothaft @pbashyal-nmdp |
Fine by me. |
maybe you can also update it to use 2.2.1 version of Spark and 2.11.12 version of Scala? |
Test PASSed. |
Merged! Thanks @heuermh! |
We will update the compile time dependency versions for 0.24.0 and will update the Jenkins build targets as well. See #1597 |
Opened a new branch for updates to the release script.
I'm not confident this will work, the build from source instructions look for the assembly jar relative to an
${ADAM_HOME}
, which will keep moving during a release build (once at the normal depth and then nested for the build from the checked out release tag)