Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SparkFiles.getRootDirectory in local mode. #1924

Merged
merged 1 commit into from
Feb 28, 2018
Merged

Use SparkFiles.getRootDirectory in local mode. #1924

merged 1 commit into from
Feb 28, 2018

Conversation

heuermh
Copy link
Member

@heuermh heuermh commented Feb 27, 2018

SparkFiles.getRootDirectory appears to be set correctly in local mode even if SparkEnv.get.driverTmpDir is not.

Changing the fallback here appears to help bigdatagenomics/cannoli#107 work in local mode.

@coveralls
Copy link

coveralls commented Feb 27, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 82.581% when pulling 81a4c69 on heuermh:sparkfiles-get-local-mode into 26f0608 on bigdatagenomics:master.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2681/
Test PASSed.

@fnothaft fnothaft merged commit 0696fea into bigdatagenomics:master Feb 28, 2018
@heuermh heuermh deleted the sparkfiles-get-local-mode branch February 28, 2018 17:30
@heuermh heuermh added this to the 0.24.0 milestone Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnothaft fnothaft fnothaft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@heuermh @coveralls @AmplabJenkins @fnothaft