[ADAM-1697] Expand Illumina metadata regex to cover index sequences #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now includes possible index sequence characters.
|
Can one of the admins verify this patch? |
|
This change was discussed in gitter with @heuermh (actually he made the change, I just wrote the test and added the test resources). Perhaps he can review it. |
fnothaft
approved these changes
Jun 28, 2018
heuermh
requested changes
Jun 28, 2018
|
|
||
| sparkTest("Paired read names with index sequences in read names can grouped into fragments") { | ||
| val path1 = testFile("read_names_with_index_sequences_pair1.fq") | ||
| val path2 = testFile("read_names_with_index_sequences_pair1.fq") |
There was a problem hiding this comment.
I think this line should be "read_names_with_index_sequences_pair2.fq"
heuermh
changed the title
|
Fixes #1697 |
Fix typo in unit test.
|
Fixed change request from @heuermh |
|
Thank you, @pauldwolfe! |
|
Jenkins, test this please |
|
Jenkins, add to whitelist |
|
Test PASSed. |
heuermh
approved these changes
Jun 28, 2018
|
Squashed and merged as commit e7cbfcd, thank you, @pauldwolfe! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now includes possible index sequence characters.