[ADAM-1992] Make maximum FASTQ read length configurable. #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
Test PASSed. |
heuermh
requested changes
Jul 7, 2018
| @@ -60,6 +60,13 @@ | |||
| * application. We'll see if someone complains in other applications. | |||
| */ | |||
|
|
|||
| public static final String MAX_READ_LENGTH_PROPERTY = "org.bdgenomics.adam.io.FastqRecordReader.MAX_READ_LENGTH"; | |||
|
|
|||
| public static void setMaxReadLength(Configuration conf, | |||
There was a problem hiding this comment.
Code style: add javadocs, make parameters final
| @@ -60,6 +60,13 @@ | |||
| * application. We'll see if someone complains in other applications. | |||
| */ | |||
|
|
|||
| public static final String MAX_READ_LENGTH_PROPERTY = "org.bdgenomics.adam.io.FastqRecordReader.MAX_READ_LENGTH"; | |||
There was a problem hiding this comment.
add
public static final int DEFAULT_MAX_READ_LENGTH = 10000;| @@ -104,7 +111,7 @@ | |||
| /** | |||
| * Maximum length for a read string. | |||
| */ | |||
| private static final int MAX_LINE_LENGTH = 10000; | |||
| private int MAX_LINE_LENGTH; | |||
There was a problem hiding this comment.
Code style: lower camel case variable name
| @@ -135,6 +142,8 @@ | |||
| */ | |||
| protected FastqRecordReader(final Configuration conf, | |||
| final FileSplit split) throws IOException { | |||
| MAX_LINE_LENGTH = conf.getInt(MAX_READ_LENGTH_PROPERTY, 10000); | |||
There was a problem hiding this comment.
use DEFAULT_MAX_READ_LENGTH above
|
Closing in favor of #2077 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1992.