Refactor/mark buckets #2015
Closed
Refactor/mark buckets #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jondeaton
commented
Jul 13, 2018
| @@ -96,14 +94,20 @@ private[rdd] object MarkDuplicates extends Serializable with Logging { | |||
| recordGroups: RecordGroupDictionary): RDD[SingleReadBucket] = { | |||
| checkRecordGroups(recordGroups) | |||
|
|
|||
| // Gets the library of a SingleReadBucket | |||
| def getLibrary(singleReadBucket: SingleReadBucket): Option[String] = { | |||
There was a problem hiding this comment.
It might also be better to make library a method of SingleReadBucket to replace this getLibrary function.
|
Can one of the admins verify this patch? |
|
Jenkins, test this please |
|
Jenkins, add to whitelist |
2 similar comments
|
Test PASSed. |
|
Closing as WontFix. Feel free to create a new PR after rebasing against git head. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The leftPositionAndLibrary function in markBuckets was a bit hard to understand. This PR refactors it so that it is easier to understand and also so that it uses
Option(None)instead ofnull. Also minor documentation fix.