FastaConverter Refactor #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arahuja
commented
Apr 8, 2014
arahuja
commented
- Bug in FastaConverter where it would incorrectly identify the header line with an associated sequence (see broken test case on older code (https://github.com/hammerlab/adam/compare/fasta-branch?expand=1)
- General cleanup, splitting out into functions for readability
- Added adamSequenceLoad to load either fasta or adam sequences
|
Can one of the admins verify this patch? |
|
Jenkins, add to whitelist and test this please. |
| .map(kv => (kv._1.get._2, kv._2)) | ||
| .groupByKey() | ||
| sequenceLines.keyBy(row => findContigIndex(row._1, indexToContigDescription.value.keys.toList)) | ||
| .map(kv => (kv._1.get, kv._2)) |
There was a problem hiding this comment.
This get is not doing anything
|
All automated tests passed. |
|
This looks ready to me but it needs to be run through scalariform, @arahuja Can you update this pull request? |
|
All automated tests passed. |
|
Thanks, Arun! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.