-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement contig-to-RefSeq translation, refactor SequenceDictionary with... #238
Conversation
…ith RefSeq information (and without numeric IDs) and prepare ADAMGenotype for incorporating reference model information.
All automated tests passed. |
adamVariants.flatMap(p => p.genotypes).adamSave(args.outputPath, | ||
blockSize = args.blockSize, pageSize = args.pageSize, | ||
|
||
def getDictionaryFile(name: String): Option[File] = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is identical to the one in ADAM2Vcf. It probably makes sense to factor our getDictionary into a separate class that both use.
…omments in PR re: incorporation of RefSeq IDs into SequenceDictioanry
All automated tests passed. |
…equenceDictioanry
All automated tests passed. |
import org.bdgenomics.adam.models.SequenceDictionary | ||
import net.sf.samtools.SAMFileReader | ||
|
||
trait DictionaryCommand { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this trait. Good idea!
Thanks, Michael! Love all the tests and clean code. |
Can you rebase this onto master? Once that's done, this is ready to merge. |
... RefSeq information (and without numeric IDs) and prepare ADAMGenotype for incorporating reference model information.
This started as a series of small edits to ADAMVariant/ADAMGenotype, but then started sprawling… First part of addressing #158.