Fix unmapped reads in sequence dictionary #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Unmapped reads should be properly handled when loading from sequence dictionary
- Unmapped reads should not try to go into the sequence dictionary to get their information, nor even set their reference id/name
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. |
|
All automated tests passed. |
|
These look good to me, Carl. |
| import org.apache.spark.rdd.RDD | ||
|
|
||
| class Bam2AdamSuite extends SparkFunSuite { | ||
| sparkTest("Bam2Adam should not fail on unmapped reads") { |
There was a problem hiding this comment.
Thanks for the test case to catch this in the future.
massie
added a commit
that referenced
this pull request
Dec 12, 2013
…equenceDictionary Fix unmapped reads in sequence dictionary
|
Thanks, Carl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue that @fnothaft described in an email; the test in e53ac85 fails in the same way (a NoSuchElementException); the changes in f47aa0c makes this test pass.