-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifying conversion code to resolve #112. #260
Conversation
All automated tests passed. |
I merged another of your PR's, so don't forget to rebase this one! |
@tdanford rebased! |
All automated tests passed. |
// - secondary is a "less good" linear alignment | ||
// - supplementary is a non-primary linear alignment in a chimeric alignment | ||
union { boolean, null } primaryAlignment = false; | ||
union { boolean, null } secondaryAlignment = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I read the code above correctly, your new "secondaryAlignment" flag is equivalent to "mapped, but not primary or supplementary." Is that right? If so, can you clarify the description in the comment block above?
Also, is there any interaction here with the code in ReadBucket and SingleReadBucket? In particular, there are already fields in those classes with particles like "secondary" in their names -- do they match the use of this "secondaryAlignment" flag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the comment. I'm not going to touch the ReadBucket/SingleReadBucket code. I think primary/secondary there maps to primary/(secondary || supplemental), but it's not clear. @massie, can you clarify?
All automated tests passed. |
Modifying conversion code to resolve #112.
Thanks, Frank! |
Resolves #112. Specifically: