Use maven license plugin to ensure source has correct license #278
Conversation
| ``` | ||
| $ mvn org.scalariform:scalariform-maven-plugin:format | ||
| $ ./scripts/format-source |
There was a problem hiding this comment.
Does that have to be run manually, or is it still part of our build process?
There was a problem hiding this comment.
Both. We decided against being too magical/automatic. The pull request builder runs it with each pull request to make sure the developer ran it.
|
I'm concerned about how this will impact our performance; @massie have you benchmarked this change? |
|
All automated tests passed. |
|
@fnothaft I have a whole suite of tests written that you can expect in a follow-on pull request. The suite is too extensive and large to include here. |
|
@massie I eagerly await it. |
Use maven license plugin to ensure source has correct license
|
Thanks @massie! I look forward to the follow-on tests. |
|
We are going to spend the next two hundred years trying to recreate the inclusive test-suite Matt alluded to in the margins above. |
No description provided.