Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in implicit conversion functions for going between Java and Scala... #3

Merged
merged 0 commits into from
Nov 25, 2013

Conversation

massie
Copy link
Member

@massie massie commented Nov 21, 2013

... types. Makes pushing data between Scala/Java/Avro a bit cleaner.

@massie
Copy link
Member Author

massie commented Nov 21, 2013

Note: This is Frank's pull request submitted to the old repo in my personal account.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@AmplabJenkins
Copy link

Merged build finished.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM/31/


object ImplicitJavaConversions {

implicit def listToJavaList [A] (list: List[A]): java.util.List[A] = seqAsJavaList (list)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be easier to maintain if we put these implicits in the AdamContext object with the others. Putting them there keeps them all in one place and makes them available to anyone who imports AdamContext._.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@AmplabJenkins
Copy link

Merged build finished.

@AmplabJenkins
Copy link

One or more automated tests failed
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM%202/1/

@fnothaft fnothaft merged commit da4184c into master Nov 25, 2013
@fnothaft
Copy link
Member

This is not merged... cleaning and reopening.

mlinderm pushed a commit to mlinderm/adam that referenced this pull request Feb 5, 2014
Sent varIsFiltered appropriately if FILTER is PASS or "."
ryan-williams added a commit to ryan-williams/adam that referenced this pull request Nov 18, 2016
reduce project to adam-core, port to sbt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants