-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding in implicit conversion functions for going between Java and Scala... #3
Conversation
Note: This is Frank's pull request submitted to the old repo in my personal account. |
Merged build triggered. |
Merged build started. |
Merged build finished. |
All automated tests passed. |
|
||
object ImplicitJavaConversions { | ||
|
||
implicit def listToJavaList [A] (list: List[A]): java.util.List[A] = seqAsJavaList (list) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be easier to maintain if we put these implicits in the AdamContext object with the others. Putting them there keeps them all in one place and makes them available to anyone who imports AdamContext._.
Merged build triggered. |
Merged build started. |
Merged build finished. |
One or more automated tests failed |
This is not merged... cleaning and reopening. |
Sent varIsFiltered appropriately if FILTER is PASS or "."
reduce project to adam-core, port to sbt
... types. Makes pushing data between Scala/Java/Avro a bit cleaner.