Stores original position and original cigar during realignment. #417

niranjan93 · 2014-10-14T06:56:11Z

Stores original position and original cigar during realignment.
Addresses issue #348 in the adam project.

AmplabJenkins · 2014-10-14T06:58:00Z

Can one of the admins verify this patch?

fnothaft · 2014-10-14T06:58:33Z

Jenkins, add to whitelist.

AmplabJenkins · 2014-10-14T07:04:38Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/296/

Build result: FAILURE

GitHub pull request #417 of commit ae38a31 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/417/merge^{commit} # timeout=10Checking out Revision 4f3e5b7 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 4f3e5b7 > git rev-list fa32bbf # timeout=10First time build. Skipping changelog.Triggering ADAM-prb » 2.2.0,centosTriggering ADAM-prb » 1.0.4,centosTriggering ADAM-prb » 2.3.0,centosADAM-prb » 2.2.0,centos completed with result FAILUREADAM-prb » 1.0.4,centos completed with result FAILUREADAM-prb » 2.3.0,centos completed with result FAILURE
Test FAILed.

fnothaft · 2014-10-14T23:58:46Z

Jenkins, retest this please.

AmplabJenkins · 2014-10-15T00:04:05Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/304/

Build result: FAILURE

GitHub pull request #417 of commit ae38a31 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/417/merge^{commit} # timeout=10Checking out Revision 7406d00 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 7406d00 > git rev-list db0f900 # timeout=10Triggering ADAM-prb » 2.3.0,centosTriggering ADAM-prb » 2.2.0,centosTriggering ADAM-prb » 1.0.4,centosADAM-prb » 2.3.0,centos completed with result FAILUREADAM-prb » 2.2.0,centos completed with result FAILUREADAM-prb » 1.0.4,centos completed with result FAILURE
Test FAILed.

AmplabJenkins · 2014-10-20T18:23:52Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/307/

Build result: FAILURE

GitHub pull request #417 of commit 77ea367 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/417/merge^{commit} # timeout=10Checking out Revision 01b4a29 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 01b4a29 > git rev-list db0f900 # timeout=10Triggering ADAM-prb » 1.0.4,centosTriggering ADAM-prb » 2.3.0,centosTriggering ADAM-prb » 2.2.0,centosADAM-prb » 1.0.4,centos completed with result FAILUREADAM-prb » 2.3.0,centos completed with result FAILUREADAM-prb » 2.2.0,centos completed with result FAILURE
Test FAILed.

AmplabJenkins · 2014-10-21T23:17:13Z

Can one of the admins verify this patch?

fnothaft · 2014-10-21T23:17:51Z

Jenkins, add to whitelist.

AmplabJenkins · 2014-10-21T23:23:59Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/309/

Build result: FAILURE

GitHub pull request #417 of commit 77ea367.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse 77ea367^{commit} # timeout=10Checking out Revision 77ea367 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 77ea367 > git rev-list db0f900 # timeout=10Triggering ADAM-prb » 1.0.4,centosTriggering ADAM-prb » 2.3.0,centosTriggering ADAM-prb » 2.2.0,centosADAM-prb » 1.0.4,centos completed with result FAILUREADAM-prb » 2.3.0,centos completed with result FAILUREADAM-prb » 2.2.0,centos completed with result FAILURE
Test FAILed.

AmplabJenkins · 2014-10-31T03:03:41Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/328/

Build result: FAILURE

GitHub pull request #417 of commit f3ef0c8 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/417/merge^{commit} # timeout=10Checking out Revision 2592f2c (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 2592f2c > git rev-list a9008c4 # timeout=10Triggering ADAM-prb » 2.2.0,centosTriggering ADAM-prb » 1.0.4,centosTriggering ADAM-prb » 2.3.0,centosADAM-prb » 2.2.0,centos completed with result FAILUREADAM-prb » 1.0.4,centos completed with result FAILUREADAM-prb » 2.3.0,centos completed with result FAILURE
Test FAILed.

AmplabJenkins · 2014-10-31T05:24:07Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/331/

Build result: FAILURE

GitHub pull request #417 of commit f0bc0f0 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/417/merge^{commit} # timeout=10Checking out Revision 7dc5bba (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 7dc5bba > git rev-list c12c117 # timeout=10Triggering ADAM-prb » 2.2.0,centosTriggering ADAM-prb » 1.0.4,centosTriggering ADAM-prb » 2.3.0,centosADAM-prb » 2.2.0,centos completed with result FAILUREADAM-prb » 1.0.4,centos completed with result FAILUREADAM-prb » 2.3.0,centos completed with result FAILURE
Test FAILed.

AmplabJenkins · 2014-10-31T18:48:34Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/333/

Build result: FAILURE

GitHub pull request #417 of commit 4186c74 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/417/merge^{commit} # timeout=10Checking out Revision 905bb58d27ebdf9a7b4cebedee15265f3ddbfbba (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 905bb58d27ebdf9a7b4cebedee15265f3ddbfbba > git rev-list 7dc5bba # timeout=10Triggering ADAM-prb » 2.2.0,centosTriggering ADAM-prb » 1.0.4,centosTriggering ADAM-prb » 2.3.0,centosADAM-prb » 2.2.0,centos completed with result FAILUREADAM-prb » 1.0.4,centos completed with result SUCCESSADAM-prb » 2.3.0,centos completed with result FAILURE
Test FAILed.

AmplabJenkins · 2014-10-31T19:04:06Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/334/
Test PASSed.

massie · 2014-11-01T04:43:32Z

pom.xml

@@ -135,7 +135,7 @@
 <configuration>
 <rules>
 <requireMavenVersion>
- <version>[3.1.1,)</version>
+ <version>[3.0.4,)</version>


Was this intentional? Some users have reported issues building with Maven 3.0.x.

massie · 2014-11-01T04:44:34Z

Aside from relaxing the Maven version requirement, this code looks ready to merge to me.

niranjan93 · 2014-11-01T20:39:26Z

Should I change it to 3.1.1? What is the preferred Maven version?

massie · 2014-11-01T21:09:58Z

Yes. 3.1.1 please.

-Matt
(Sent from phone)
On Nov 1, 2014 1:39 PM, "niranjan93" notifications@github.com wrote:

Should I change it to 3.1.1? What is the preferred Maven version?

—
Reply to this email directly or view it on GitHub
#417 (comment).

niranjan93 · 2014-11-01T21:27:49Z

Unfortunately, changing the version from 3.0.4 to 3.1.1 causes the build to fail:

niranjan93@crick:~/adam$ mvn test
[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.bdgenomics.adam:adam-core:jar:0.14.1-SNAPSHOT
[WARNING] 'dependencies.dependency.exclusions.exclusion.artifactId' for org.apache.hadoop:hadoop-client:jar with value '' does not match a valid id pattern. @ org.bdgenomics.adam:adam-parent:0.14.1-SNAPSHOT, /home/niranjan93/adam/pom.xml, line 364, column 25
[WARNING] 'dependencies.dependency.exclusions.exclusion.artifactId' for org.apache.hadoop:hadoop-client:jar with value '' does not match a valid id pattern. @ org.bdgenomics.adam:adam-parent:0.14.1-SNAPSHOT, /home/niranjan93/adam/pom.xml, line 368, column 25
[WARNING] 'dependencyManagement.dependencies.dependency.exclusions.exclusion.artifactId' for org.apache.hadoop:hadoop-client:jar with value '' does not match a valid id pattern. @ org.bdgenomics.adam:adam-parent:0.14.1-SNAPSHOT, /home/niranjan93/adam/pom.xml, line 364, column 25
[WARNING] 'dependencyManagement.dependencies.dependency.exclusions.exclusion.artifactId' for org.apache.hadoop:hadoop-client:jar with value '' does not match a valid id pattern. @ org.bdgenomics.adam:adam-parent:0.14.1-SNAPSHOT, /home/niranjan93/adam/pom.xml, line 368, column 25
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.bdgenomics.adam:adam-apis:jar:0.14.1-SNAPSHOT
[WARNING] 'dependencyManagement.dependencies.dependency.exclusions.exclusion.artifactId' for org.apache.hadoop:hadoop-client:jar with value '' does not match a valid id pattern. @ org.bdgenomics.adam:adam-parent:0.14.1-SNAPSHOT, /home/niranjan93/adam/pom.xml, line 364, column 25
[WARNING] 'dependencyManagement.dependencies.dependency.exclusions.exclusion.artifactId' for org.apache.hadoop:hadoop-client:jar with value '' does not match a valid id pattern. @ org.bdgenomics.adam:adam-parent:0.14.1-SNAPSHOT, /home/niranjan93/adam/pom.xml, line 368, column 25
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.bdgenomics.adam:adam-cli:jar:0.14.1-SNAPSHOT
[WARNING] 'dependencyManagement.dependencies.dependency.exclusions.exclusion.artifactId' for org.apache.hadoop:hadoop-client:jar with value '' does not match a valid id pattern. @ org.bdgenomics.adam:adam-parent:0.14.1-SNAPSHOT, /home/niranjan93/adam/pom.xml, line 364, column 25
[WARNING] 'dependencyManagement.dependencies.dependency.exclusions.exclusion.artifactId' for org.apache.hadoop:hadoop-client:jar with value '' does not match a valid id pattern. @ org.bdgenomics.adam:adam-parent:0.14.1-SNAPSHOT, /home/niranjan93/adam/pom.xml, line 368, column 25
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.bdgenomics.adam:adam-parent:pom:0.14.1-SNAPSHOT
[WARNING] 'dependencyManagement.dependencies.dependency.exclusions.exclusion.artifactId' for org.apache.hadoop:hadoop-client:jar with value '' does not match a valid id pattern. @ line 364, column 25
[WARNING] 'dependencyManagement.dependencies.dependency.exclusions.exclusion.artifactId' for org.apache.hadoop:hadoop-client:jar with value '' does not match a valid id pattern. @ line 368, column 25
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] ADAM
[INFO] ADAM: Core
[INFO] ADAM: APIs for Java
[INFO] ADAM: CLI
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building ADAM 0.14.1-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-enforcer-plugin:1.0:enforce (enforce-versions) @ adam-parent ---
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireMavenVersion failed with message:
ADAM requires Maven 3.1.1 or greater
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] ADAM .............................................. FAILURE [0.631s]
[INFO] ADAM: Core ........................................ SKIPPED
[INFO] ADAM: APIs for Java ............................... SKIPPED
[INFO] ADAM: CLI ......................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 0.981s
[INFO] Finished at: Sat Nov 01 14:25:47 PDT 2014
[INFO] Final Memory: 21M/1963M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:1.0:enforce (enforce-versions) on project adam-parent: Some Enforcer rules have failed. Look above for specific messages explaining why the rule failed. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

AmplabJenkins · 2014-11-01T21:39:04Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/342/
Test PASSed.

massie · 2014-11-01T21:42:45Z

I believe that someone fixed this. I just checked and the Maven version for
ADAM and ADAM pull request builder are 3.1.1. All your tests passed! Looks
good.

-Matt

On Sat, Nov 1, 2014 at 2:39 PM, UCB AMPLab notifications@github.com wrote:

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/342/
Test PASSed.

—
Reply to this email directly or view it on GitHub
#417 (comment).

massie · 2014-11-01T21:44:24Z

pom.xml

@@ -305,7 +305,7 @@
 <dependency>
 <groupId>org.bdgenomics.bdg-formats</groupId>
 <artifactId>bdg-formats</artifactId>
- <version>0.3.1</version>
+ <version>0.3.2</version>


Is the bump to bdg-formats intentional?

niranjan93 · 2014-11-01T22:31:14Z

I'm not actually sure why it's 0.3.2. Should I change it to 0.3.1?

massie · 2014-11-01T22:37:26Z

Yes, please. Once you change it to 0.3.1, I'll be happy to merge this code.
Thanks for the contribution!

-Matt

On Sat, Nov 1, 2014 at 3:31 PM, niranjan93 notifications@github.com wrote:

I'm not actually sure why it's 0.3.2. Should I change it to 0.3.1?

—
Reply to this email directly or view it on GitHub
#417 (comment).

AmplabJenkins · 2014-11-01T23:18:42Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/343/

Build result: FAILURE

GitHub pull request #417 of commit ccc640b automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/417/merge^{commit} # timeout=10Checking out Revision 5a3a8ea90533d65453d705fda97b9408ec65e730 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 5a3a8ea90533d65453d705fda97b9408ec65e730 > git rev-list c648a6f2090c2b8df001dfef497bea6c70f02df4 # timeout=10Triggering ADAM-prb » 2.2.0,centosTriggering ADAM-prb » 1.0.4,centosTriggering ADAM-prb » 2.3.0,centosADAM-prb » 2.2.0,centos completed with result FAILUREADAM-prb » 1.0.4,centos completed with result FAILUREADAM-prb » 2.3.0,centos completed with result FAILURE
Test FAILed.

fnothaft · 2014-11-01T23:31:22Z

@massie the bdg-formats dependency needs to be 0.3.2; we added the originalCigar and originalPosition fields in 0.3.2.

…ment. Addresses issue bigdatagenomics#348 in the adam project.

AmplabJenkins · 2014-11-01T23:39:03Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/344/

Build result: FAILURE

GitHub pull request #417 of commit fef9713 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/417/merge^{commit} # timeout=10Checking out Revision a7a2569f68f2981425bb14e2fffc1bdbd8024b8c (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f a7a2569f68f2981425bb14e2fffc1bdbd8024b8c > git rev-list 5a3a8ea90533d65453d705fda97b9408ec65e730 # timeout=10Triggering ADAM-prb » 2.2.0,centosTriggering ADAM-prb » 1.0.4,centosTriggering ADAM-prb » 2.3.0,centosADAM-prb » 2.2.0,centos completed with result FAILUREADAM-prb » 1.0.4,centos completed with result FAILUREADAM-prb » 2.3.0,centos completed with result FAILURE
Test FAILed.

niranjan93 · 2014-11-01T23:46:17Z

I changed 0.3.1 back to 0.3.2, but the build still fails. I made sure that I didn't change anything else. I also did another rebase before pushing, but Git notified me that everything is up to date.

niranjan93@crick:/adam$ git fetch upstream
niranjan93@crick:/adam$ git status

On branch NK_schema_tags

nothing to commit (working directory clean)
niranjan93@crick:/adam$ git rebase upstream/master
Current branch NK_schema_tags is up to date.
niranjan93@crick:/adam$

niranjan93 · 2014-11-01T23:47:28Z

I have no idea why the font became so big. I had just pasted the command line output from crick. Sorry.

massie · 2014-11-02T01:10:32Z

Jenkins, retest this please.

massie · 2014-11-02T01:18:14Z

@niranjan93

There is no need to be sorry. Hopefully the tests will pass now.

fnothaft · 2014-11-02T01:24:37Z

Big fonts are back in vogue; it's like hair in the 80's. ;)

AmplabJenkins · 2014-11-02T01:28:40Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/345/
Test PASSed.

Stores original position and original cigar during realignment.

niranjan93 · 2014-11-02T01:31:42Z

I see it passes now. Thanks Matt! Thanks Frank!

massie · 2014-11-02T01:31:49Z

Thanks, @niranjan93 !

niranjan93 force-pushed the NK_schema_tags branch from ae38a31 to 77ea367 Compare October 20, 2014 18:13

niranjan93 force-pushed the NK_schema_tags branch from 77ea367 to f3ef0c8 Compare October 31, 2014 02:54

niranjan93 force-pushed the NK_schema_tags branch from f3ef0c8 to f0bc0f0 Compare October 31, 2014 05:08

niranjan93 force-pushed the NK_schema_tags branch from 4186c74 to c3c848c Compare October 31, 2014 18:34

massie reviewed Nov 1, 2014
View reviewed changes

niranjan93 force-pushed the NK_schema_tags branch from c3c848c to e20ec43 Compare November 1, 2014 21:22

massie reviewed Nov 1, 2014
View reviewed changes

niranjan93 force-pushed the NK_schema_tags branch from e20ec43 to ccc640b Compare November 1, 2014 23:14

[ADAM-348] Stores original position and original cigar during realign…

fef9713

…ment. Addresses issue bigdatagenomics#348 in the adam project.

niranjan93 force-pushed the NK_schema_tags branch from ccc640b to fef9713 Compare November 1, 2014 23:34

massie added a commit that referenced this pull request Nov 2, 2014

Merge pull request #417 from niranjan93/NK_schema_tags

c4e8e23

Stores original position and original cigar during realignment.

massie merged commit c4e8e23 into bigdatagenomics:master Nov 2, 2014

fnothaft mentioned this pull request Feb 8, 2015

Store original position/cigar during realignment #348

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stores original position and original cigar during realignment. #417

Stores original position and original cigar during realignment. #417

niranjan93 commented Oct 14, 2014

AmplabJenkins commented Oct 14, 2014

fnothaft commented Oct 14, 2014

AmplabJenkins commented Oct 14, 2014

fnothaft commented Oct 14, 2014

AmplabJenkins commented Oct 15, 2014

AmplabJenkins commented Oct 20, 2014

AmplabJenkins commented Oct 21, 2014

fnothaft commented Oct 21, 2014

AmplabJenkins commented Oct 21, 2014

AmplabJenkins commented Oct 31, 2014

AmplabJenkins commented Oct 31, 2014

AmplabJenkins commented Oct 31, 2014

AmplabJenkins commented Oct 31, 2014

massie Nov 1, 2014

massie commented Nov 1, 2014

niranjan93 commented Nov 1, 2014

massie commented Nov 1, 2014

niranjan93 commented Nov 1, 2014

AmplabJenkins commented Nov 1, 2014

massie commented Nov 1, 2014

massie Nov 1, 2014

niranjan93 commented Nov 1, 2014

massie commented Nov 1, 2014

AmplabJenkins commented Nov 1, 2014

fnothaft commented Nov 1, 2014

AmplabJenkins commented Nov 1, 2014

niranjan93 commented Nov 1, 2014

niranjan93 commented Nov 1, 2014

massie commented Nov 2, 2014

massie commented Nov 2, 2014

fnothaft commented Nov 2, 2014

AmplabJenkins commented Nov 2, 2014

niranjan93 commented Nov 2, 2014

massie commented Nov 2, 2014

Stores original position and original cigar during realignment. #417

Stores original position and original cigar during realignment. #417

Conversation

niranjan93 commented Oct 14, 2014

AmplabJenkins commented Oct 14, 2014

fnothaft commented Oct 14, 2014

AmplabJenkins commented Oct 14, 2014

Build result: FAILURE

fnothaft commented Oct 14, 2014

AmplabJenkins commented Oct 15, 2014

Build result: FAILURE

AmplabJenkins commented Oct 20, 2014

Build result: FAILURE

AmplabJenkins commented Oct 21, 2014

fnothaft commented Oct 21, 2014

AmplabJenkins commented Oct 21, 2014

Build result: FAILURE

AmplabJenkins commented Oct 31, 2014

Build result: FAILURE

AmplabJenkins commented Oct 31, 2014

Build result: FAILURE

AmplabJenkins commented Oct 31, 2014

Build result: FAILURE

AmplabJenkins commented Oct 31, 2014

massie Nov 1, 2014

Choose a reason for hiding this comment

massie commented Nov 1, 2014

niranjan93 commented Nov 1, 2014

massie commented Nov 1, 2014

niranjan93 commented Nov 1, 2014

AmplabJenkins commented Nov 1, 2014

massie commented Nov 1, 2014

massie Nov 1, 2014

Choose a reason for hiding this comment

niranjan93 commented Nov 1, 2014

massie commented Nov 1, 2014

AmplabJenkins commented Nov 1, 2014

Build result: FAILURE

fnothaft commented Nov 1, 2014

AmplabJenkins commented Nov 1, 2014

Build result: FAILURE

niranjan93 commented Nov 1, 2014

On branch NK_schema_tags

niranjan93 commented Nov 1, 2014

massie commented Nov 2, 2014

massie commented Nov 2, 2014

There is no need to be sorry. Hopefully the tests will pass now.

fnothaft commented Nov 2, 2014

Big fonts are back in vogue; it's like hair in the 80's. ;)

AmplabJenkins commented Nov 2, 2014

niranjan93 commented Nov 2, 2014

massie commented Nov 2, 2014

Thanks, @niranjan93 !