Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move non-genomics code #478

Merged
merged 6 commits into from
Feb 4, 2015
Merged

Conversation

fnothaft
Copy link
Member

This resolves #475 by removing the non-genomics specific code which has been migrated to bdg-utils, and pointing at bdg-utils where necessary. Specifically, we've moved the:

  • SparkFunSuite
  • Parquet reimplementation
  • Metrics
  • Instrumentation

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/397/

Build result: FAILURE

GitHub pull request #478 of commit f9812dc automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/478/merge^{commit} # timeout=10Checking out Revision 342c0ae (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 342c0ae > git rev-list cc683a5 # timeout=10Triggering ADAM-prb » 2.3.0,centosTriggering ADAM-prb » 1.0.4,centosTriggering ADAM-prb » 2.2.0,centosADAM-prb » 2.3.0,centos completed with result FAILUREADAM-prb » 1.0.4,centos completed with result FAILUREADAM-prb » 2.2.0,centos completed with result FAILURE
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/398/

Build result: FAILURE

GitHub pull request #478 of commit d759957 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/478/merge^{commit} # timeout=10Checking out Revision f98c346 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f f98c346 > git rev-list cc683a5 # timeout=10Triggering ADAM-prb » 2.3.0,centosTriggering ADAM-prb » 1.0.4,centosTriggering ADAM-prb » 2.2.0,centosADAM-prb » 2.3.0,centos completed with result FAILUREADAM-prb » 1.0.4,centos completed with result FAILUREADAM-prb » 2.2.0,centos completed with result FAILURE
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/400/
Test PASSed.

@tdanford
Copy link
Contributor

See the notes in #472, I think merging this should wait on merging that PR first.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/567/

Build result: FAILURE

GitHub pull request #478 of commit 64e2752 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/478/merge^{commit} # timeout=10Checking out Revision 93cb1940a73c7a2b9fb05142628e5c04c2d757c4 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 93cb1940a73c7a2b9fb05142628e5c04c2d757c4 > git rev-list d8e02d9 # timeout=10Triggering ADAM-prb ? 2.3.0,centosTriggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosADAM-prb ? 2.3.0,centos completed with result FAILUREADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILURE
Test FAILed.

@fnothaft
Copy link
Member Author

I expect this failure because I was building against bigdatagenomics/utils#19. This will pass once bigdatagenomics/utils#19 is merged.

@fnothaft
Copy link
Member Author

Ta-da! And, this now is working with @nfergu's work from #514 on top, and building against bigdatagenomics/utils#19. The build will fail here though, since we haven't merged bigdatagenomics/utils#19 upstream.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/568/

Build result: FAILURE

GitHub pull request #478 of commit 0caf693 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/478/merge^{commit} # timeout=10Checking out Revision 33636cc5c1192c50966bb7fb69ff33cbef865994 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 33636cc5c1192c50966bb7fb69ff33cbef865994 > git rev-list d8e02d9 # timeout=10Triggering ADAM-prb ? 2.3.0,centosTriggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosADAM-prb ? 2.3.0,centos completed with result FAILUREADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILURE
Test FAILed.

@massie
Copy link
Member

massie commented Jan 28, 2015

Switching to SparkFunSuite in bdg-utils will revert the work I did in ADAM to fix all the test bind errors. We need to port that into bdg-utils.

@fnothaft
Copy link
Member Author

@massie thanks for catching that! I will port that right now.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/569/

Build result: FAILURE

GitHub pull request #478 of commit 71efd46 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/478/merge^{commit} # timeout=10Checking out Revision 6ef8e42 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 6ef8e42 > git rev-list d8e02d9 # timeout=10Triggering ADAM-prb ? 2.3.0,centosTriggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosADAM-prb ? 2.3.0,centos completed with result FAILUREADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILURE
Test FAILed.

@fnothaft
Copy link
Member Author

Jenkins, retest this please.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/570/

Build result: FAILURE

GitHub pull request #478 of commit 71efd46 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/478/merge^{commit} # timeout=10Checking out Revision 6ef8e42 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 6ef8e42 > git rev-list d8e02d9 # timeout=10Triggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosTriggering ADAM-prb ? 2.3.0,centosADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILUREADAM-prb ? 2.3.0,centos completed with result FAILURE
Test FAILed.

@fnothaft
Copy link
Member Author

fnothaft commented Feb 1, 2015

Once bigdatagenomics/utils#22 is merged, this will pass.

@massie
Copy link
Member

massie commented Feb 2, 2015

Jenkins, test this please.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/571/

Build result: FAILURE

GitHub pull request #478 of commit 71efd46 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/478/merge^{commit} # timeout=10Checking out Revision 6ef8e42 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 6ef8e42 > git rev-list d8e02d9 # timeout=10Triggering ADAM-prb ? 1.0.4,centosTriggering ADAM-prb ? 2.3.0,centosTriggering ADAM-prb ? 2.2.0,centosADAM-prb ? 1.0.4,centos completed with result FAILUREADAM-prb ? 2.3.0,centos completed with result FAILUREADAM-prb ? 2.2.0,centos completed with result FAILURE
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/572/

Build result: FAILURE

GitHub pull request #478 of commit ea77c10 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/478/merge^{commit} # timeout=10Checking out Revision cc1e819a0f1930f38a1e30509db24aa12b3280e4 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f cc1e819a0f1930f38a1e30509db24aa12b3280e4 > git rev-list d8e02d9 # timeout=10Triggering ADAM-prb ? 1.0.4,centosTriggering ADAM-prb ? 2.3.0,centosTriggering ADAM-prb ? 2.2.0,centosADAM-prb ? 1.0.4,centos completed with result SUCCESSADAM-prb ? 2.3.0,centos completed with result FAILUREADAM-prb ? 2.2.0,centos completed with result FAILURE
Test FAILed.

@fnothaft
Copy link
Member Author

fnothaft commented Feb 2, 2015

Jenkins, retest this please.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/573/

Build result: FAILURE

GitHub pull request #478 of commit ea77c10 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/478/merge^{commit} # timeout=10Checking out Revision cc1e819a0f1930f38a1e30509db24aa12b3280e4 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f cc1e819a0f1930f38a1e30509db24aa12b3280e4 > git rev-list d8e02d9 # timeout=10Triggering ADAM-prb ? 1.0.4,centosTriggering ADAM-prb ? 2.3.0,centosTriggering ADAM-prb ? 2.2.0,centosADAM-prb ? 1.0.4,centos completed with result SUCCESSADAM-prb ? 2.3.0,centos completed with result FAILUREADAM-prb ? 2.2.0,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@fnothaft
Copy link
Member Author

fnothaft commented Feb 2, 2015

Jenkins, test this please.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/574/
Test PASSed.

@fnothaft
Copy link
Member Author

fnothaft commented Feb 3, 2015

Now that this really is passing, I've cut a new bdg-utils release. I'll update this PR once that release is present in Maven Central.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/575/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/576/
Test PASSed.

@fnothaft fnothaft mentioned this pull request Feb 4, 2015
@massie
Copy link
Member

massie commented Feb 4, 2015

Thanks, Frank!

massie added a commit that referenced this pull request Feb 4, 2015
@massie massie merged commit cd67c1c into bigdatagenomics:master Feb 4, 2015
@nfergu
Copy link
Contributor

nfergu commented Feb 4, 2015

@fnothaft -- looks great! Just tried the latest version locally and it works well.

Just one comment: I think the Timers object should be in ADAM rather than bdg-utils as it contains ADAM-specific timers. I'll raise separate PRs to move it.

@fnothaft
Copy link
Member Author

fnothaft commented Feb 4, 2015

@nfergu ah, drat! You are indeed correct! I'd created an earlier version that did that correctly ;). Thanks for catching this, and I'll review and merge your two PRs shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove code that is now in bdg-utils
5 participants