Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't open non-.adam-extension files as ADAM files #523

Merged
merged 1 commit into from
Dec 17, 2014

Conversation

ryan-williams
Copy link
Member

No description provided.

@fnothaft
Copy link
Member

+1, LGTM! I'll keep it open for a bit in case anyone else wants to comment.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/493/

Build result: FAILURE

GitHub pull request #523 of commit cb56e3a automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/523/merge^{commit} # timeout=10Checking out Revision 95d2a4b (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 95d2a4b > git rev-list b750165 # timeout=10Triggering ADAM-prb ? 2.3.0,centosTriggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosADAM-prb ? 2.3.0,centos completed with result FAILUREADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILURE
Test FAILed.

@shaneknapp
Copy link
Contributor

jenkins, test this please

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/494/

Build result: FAILURE

GitHub pull request #523 of commit cb56e3a automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/523/merge^{commit} # timeout=10Checking out Revision 95d2a4b (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 95d2a4b > git rev-list b750165 # timeout=10Triggering ADAM-prb ? 2.3.0,centosTriggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosADAM-prb ? 2.3.0,centos completed with result FAILUREADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILURE
Test FAILed.

@ryan-williams
Copy link
Member Author

I believe my last commit should fix jenkins, which was failing due to needing some .adam extensions in the jenkins-test script

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/495/
Test PASSed.

@fnothaft
Copy link
Member

@ryan-williams can you squash this down? I will merge once squashed.

@ryan-williams
Copy link
Member Author

done!

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/499/
Test PASSed.

fnothaft added a commit that referenced this pull request Dec 17, 2014
don't open non-.adam-extension files as ADAM files
@fnothaft fnothaft merged commit bceb3e1 into bigdatagenomics:master Dec 17, 2014
@fnothaft
Copy link
Member

Merged! Thanks @ryan-williams!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants