-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't open non-.adam-extension files as ADAM files #523
Conversation
+1, LGTM! I'll keep it open for a bit in case anyone else wants to comment. |
Test FAILed. Build result: FAILUREGitHub pull request #523 of commit cb56e3a automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/523/merge^{commit} # timeout=10Checking out Revision 95d2a4b (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 95d2a4b > git rev-list b750165 # timeout=10Triggering ADAM-prb ? 2.3.0,centosTriggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosADAM-prb ? 2.3.0,centos completed with result FAILUREADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILURETest FAILed. |
jenkins, test this please |
Test FAILed. Build result: FAILUREGitHub pull request #523 of commit cb56e3a automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/523/merge^{commit} # timeout=10Checking out Revision 95d2a4b (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 95d2a4b > git rev-list b750165 # timeout=10Triggering ADAM-prb ? 2.3.0,centosTriggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosADAM-prb ? 2.3.0,centos completed with result FAILUREADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILURETest FAILed. |
I believe my last commit should fix jenkins, which was failing due to needing some |
Test PASSed. |
@ryan-williams can you squash this down? I will merge once squashed. |
b3953aa
to
fff3691
Compare
done! |
Test PASSed. |
don't open non-.adam-extension files as ADAM files
Merged! Thanks @ryan-williams! |
No description provided.