[ADAM-532] Fix wigFix intermittent test failure #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reading the converted output, it's possible that the order of the records is undefined. I added a sort which should make things more reliable. Fixes bigdatagenomics#532.
|
Pretty sure this should fix the problem. |
|
Test FAILed. Build result: FAILUREGitHub pull request #546 of commit 7056125 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/546/merge^{commit} # timeout=10Checking out Revision 646efe2 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 646efe2 > git rev-list b409bd0004a00c2dac712b5c567963b3e013c8e3 # timeout=10Triggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosTriggering ADAM-prb ? 2.3.0,centosADAM-prb ? 2.2.0,centos completed with result SUCCESSADAM-prb ? 1.0.4,centos completed with result FAILUREADAM-prb ? 2.3.0,centos completed with result SUCCESSTest FAILed. |
|
Jenkinst, retest this please. |
|
Jenkins, retest this please. |
|
Test PASSed. |
fnothaft
added a commit
that referenced
this pull request
Jan 10, 2015
[ADAM-532] Fix wigFix intermittent test failure
|
Merged! Thanks @laserson. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading the converted output, it's possible that the order of the records is undefined. I added a sort which should make things more reliable.
Fixes #532.