A few small conversion fixes #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
fnothaft
force-pushed
the
check-pl-bounds
branch
from
2020fdf
to
74b7844
Compare
|
Rebased. |
|
Test PASSed. |
| // Position of the mate/next segment | ||
| val mateReference: Int = samRecord.getMateReferenceIndex | ||
| // Position of the mate/next segment | ||
| val mateReference: Int = samRecord.getMateReferenceIndex |
There was a problem hiding this comment.
Is this indentation intentional? I'm surprised that Scalariform didn't complain.
There was a problem hiding this comment.
The patch modifies the conditionals surrounding this code block, which leads to an indentation change for this stretch of code.
|
Thanks, Frank! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #479. Also adds a bit of logging to the legacy format converters.