Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-513] Remove ReferenceMappable trait. #592

Merged
merged 1 commit into from
Mar 2, 2015

Conversation

fnothaft
Copy link
Member

Resolves (?) #513. Removes the ReferenceMappable trait, along with the ReferenceMappingContext. Also strips out the visualization code; @erictu will be moving this into a downstream repository.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/611/
Test PASSed.

@fnothaft
Copy link
Member Author

Rebased.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/613/
Test PASSed.

@laserson
Copy link
Contributor

Great work, @fnothaft! I'm happy to merge unless anyone has objections.

@erictu
Copy link
Member

erictu commented Mar 1, 2015

@fnothaft, should we strip out the webapp folder in adam-cli/src/main/webapp?

@tdanford
Copy link
Contributor

tdanford commented Mar 1, 2015

I like it too, although I'd (minor quibble) suggest that we could at least drop the VizReads and TrackedLayout stuff as a separate commit (if not a completely separate PR)?

@fnothaft
Copy link
Member Author

fnothaft commented Mar 1, 2015

@erictu ah, forgot that! Will fix.

@tdanford I'll split that into a separate commit.

@fnothaft
Copy link
Member Author

fnothaft commented Mar 2, 2015

Rebased following the #606 merge.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/622/
Test PASSed.

laserson added a commit that referenced this pull request Mar 2, 2015
[ADAM-513] Remove ReferenceMappable trait.
@laserson laserson merged commit 28b34b3 into bigdatagenomics:master Mar 2, 2015
@laserson
Copy link
Contributor

laserson commented Mar 2, 2015

Thanks, @fnothaft! Happy to see ReferenceMappingContext go :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants