Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeneFeatureRDDFunctions → FeatureRDDFunctions #705

Merged
merged 1 commit into from
Jun 3, 2015
Merged

GeneFeatureRDDFunctions → FeatureRDDFunctions #705

merged 1 commit into from
Jun 3, 2015

Conversation

ryan-williams
Copy link
Member

Fixes #704

fnothaft
fnothaft reviewed Jun 2, 2015
View reviewed changes
adam-core/src/main/scala/org/bdgenomics/adam/rdd/ADAMContext.scala
@@ -69,7 +69,7 @@ object ADAMContext {
implicit def rddToADAMGenotypeRDD(rdd: RDD[Genotype]) = new GenotypeRDDFunctions(rdd)

// add gene feature rdd functions
implicit def convertBaseFeatureRDDToGeneFeatureRDD(rdd: RDD[Feature]) = new GeneFeatureRDDFunctions(rdd)
implicit def convertBaseFeatureRDDToGeneFeatureRDD(rdd: RDD[Feature]) = new FeatureRDDFunctions(rdd)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/RDDToGene/RDDTo/g

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done! good catch

@fnothaft fnothaft added this to the 0.18.0 milestone Jun 3, 2015
@fnothaft
Copy link
Member

fnothaft commented Jun 3, 2015

Thanks! Can you rebase?

@ryan-williams
Copy link
Member Author

rebased!

@laserson
Copy link
Contributor

laserson commented Jun 3, 2015

lgtm

fnothaft added a commit that referenced this pull request Jun 3, 2015
@fnothaft
Merge pull request #705 from ryan-williams/gene
ae29387 
GeneFeatureRDDFunctions → FeatureRDDFunctions
@fnothaft fnothaft merged commit ae29387 into bigdatagenomics:master Jun 3, 2015
@fnothaft
Copy link
Member

fnothaft commented Jun 3, 2015

Merged! Thanks @ryan-williams!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.17.1
Development

Successfully merging this pull request may close these issues.

Rename GeneFeatureRDDFunctions → FeatureRDDFunctions
3 participants
@ryan-williams @fnothaft @laserson