Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More involved README restructuring #764

Closed
wants to merge 3 commits into from
Closed

More involved README restructuring #764

wants to merge 3 commits into from

Conversation

ryan-williams
Copy link
Member

This builds off of #763:

  • Move description of Avro, Parquet, Spark to end, in "Under the Hood" section
  • Clarify simple CLI use of count_kmers; save more involved scala-code-snippet for adam-shell example later on.
  • Update some links to non-incubator, yes-apache-project versions.
  • De-duplicate blocks showing arg-less adam-submit and adam-submit transform commands and their full output.
    • Update sample output of these commands.
  • Move info about installing Spark and setting up ADAM aliases into "Installing" section.

There's probably too much going on to get much out of Github's "rich diff", so you might want to just look at the new version in its entirety.

- Move description of Avro, Parquet, Spark to end, in "Under the Hood" section
- Clarify simple CLI use of `count_kmers`; save more involved scala-code-snippet for `adam-shell` example later on.
- Update some links to non-incubator, yes-apache-project versions.
- De-duplicate blocks showing arg-less `adam-submit` and `adam-submit transform` commands and their full output.
- Move info about installing Spark and setting up ADAM aliases into "Installing" section
- fix relative intra-page links
- update example output of arg-less `adam-submit` and `adam-submit transform` calls
- move "applications" to their own section at the end
@fnothaft
Copy link
Member

This looks really good to me! Thanks @ryan-williams. I will leave this open for more comment.


# Getting Started

## Installation

### Binary Distributions

Bundled release binaries can be found on our [releases][] page.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing URL?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@massie
Copy link
Member

massie commented Aug 11, 2015

+1

Ignore my comment noise re: the releases URL. Let's merge this later today.

For other reviewers, if you click the "View" button at the top of the "Files Changed" tab you can view the page as it will be displayed. Looks good.

@ryan-williams
Copy link
Member Author

Random related q: what is/should be the purpose of the docs/ directory and its relationship to README.md? Is it published anywhere?

@fnothaft
Copy link
Member

@ryan-williams the docs/ directory is a set of Pandoc markdown files that are intended to serve as longer, more verbose documentation (i.e., documentation beyond the README). We build and distribute these via the distribution artifact (which is only built when you do mvn package -P distribution).

@fnothaft
Copy link
Member

Thanks @ryan-williams! This is great; thanks for taking it on. I've committed this manually as 20ded3d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants