Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-780] Make DecadentRead package private. #845

Merged
merged 1 commit into from
Oct 6, 2015

Conversation

fnothaft
Copy link
Member

@fnothaft fnothaft commented Oct 5, 2015

This change changes the DecadentRead class and object from public to package
private (org.bdgenomics.adam). Additionally, we mark both items as deprecated
in favor of the RichAlignmentRecord. Resolves #780.

@fnothaft fnothaft added this to the 0.18.0 milestone Oct 5, 2015
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/957/
Test PASSed.

@heuermh
Copy link
Member

heuermh commented Oct 5, 2015

+1

This change changes the DecadentRead class and object from public to package
private (org.bdgenomics.adam). Additionally, we mark both items as deprecated
in favor of the RichAlignmentRecord. Resolves bigdatagenomics#780.
@fnothaft
Copy link
Member Author

fnothaft commented Oct 6, 2015

Rebased.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/969/
Test PASSed.

@heuermh
Copy link
Member

heuermh commented Oct 6, 2015

Thanks!

heuermh added a commit that referenced this pull request Oct 6, 2015
[ADAM-780] Make DecadentRead package private.
@heuermh heuermh merged commit 9d32233 into bigdatagenomics:master Oct 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants