P Operator parsing for MDTag #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
|
LGTM! OOC, how are you getting a |
|
We should be able to get a version 0.18.2 release out shortly with this in it, if that helps. |
|
@fnothaft @heuermh Yes, it was just a unit test that had this issue for us - is a P unexpected in the middle of a CIGAR? I did a quick look through a handful of BAMs I had honestly did not find any P's and have run other ADAM utilities without this cropping up, so I'm not sure I've ever seen a CIGAR |
|
OK! Cool. I was just curious. Let me merge this now... |
|
Thanks @arahuja! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.