-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding --version command line option #888
Conversation
Hold up, I'm missing the license header but messed up my local git repo. Might take a bit before I can rebase. |
Test PASSed. |
Test FAILed. Build result: FAILUREGitHub pull request #888 of commit 9fda722 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/888/merge^{commit} # timeout=10 > git branch -a --contains b14d5c82ca6b1b828ae68a846787add6b3488d8a # timeout=10 > git rev-parse remotes/origin/pr/888/merge^{commit} # timeout=10Checking out Revision b14d5c82ca6b1b828ae68a846787add6b3488d8a (origin/pr/888/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f b14d5c82ca6b1b828ae68a846787add6b3488d8aFirst time build. Skipping changelog.Triggering ADAM-prb ? 2.6.0,2.11,1.4.1,centosTriggering ADAM-prb ? 2.6.0,2.10,1.4.1,centosTouchstone configurations resulted in FAILURE, so aborting...Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'Test FAILed. |
@@ -19,6 +19,7 @@ | |||
<properties> | |||
<java.version>1.7</java.version> | |||
<avro.version>1.7.7</avro.version> | |||
<scala.version>2.10</scala.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't need this, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I see where this is used now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you document this in here? It's not immediately obvious that this is used by About.java
, and I'm worried that without docs, this will get removed by someone at a later date.
Test FAILed. Build result: FAILUREGitHub pull request #888 of commit a8c1467 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/888/merge^{commit} # timeout=10 > git branch -a --contains 865cd1e # timeout=10 > git rev-parse remotes/origin/pr/888/merge^{commit} # timeout=10Checking out Revision 865cd1e (origin/pr/888/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 865cd1e > git rev-list b14d5c82ca6b1b828ae68a846787add6b3488d8a # timeout=10Triggering ADAM-prb ? 2.6.0,2.11,1.4.1,centosTriggering ADAM-prb ? 2.6.0,2.10,1.4.1,centosTouchstone configurations resulted in FAILURE, so aborting...Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'Test FAILed. |
Jenkins, retest this please |
Test PASSed. |
Jenkins, retest this please |
Test FAILed. Build result: FAILUREGitHub pull request #888 of commit a8c1467 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/888/merge^{commit} # timeout=10 > git branch -a --contains c72865a # timeout=10 > git rev-parse remotes/origin/pr/888/merge^{commit} # timeout=10Checking out Revision c72865a (origin/pr/888/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f c72865a > git rev-list 865cd1e # timeout=10Triggering ADAM-prb ? 2.6.0,2.11,1.4.1,centosTriggering ADAM-prb ? 2.6.0,2.10,1.4.1,centosTouchstone configurations resulted in FAILURE, so aborting...Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'Test FAILed. |
Jenkins, retest this please |
Test PASSed. |
Thanks! |
For snapshot builds:
For release versions:
Any properties available to Maven via
pom.xml
could be added. I also fixed the kerning with our logo.