Squashed #907 and ran format-sources #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
* disuse of builtin functions for common reduce operations * unneceessary toString * risky/anti-idiomatic Option usage * Cleaning up TODOs in Vcfutils * retire VcfStringUtils * finer exception types in some places * more explicit Fastq error message in stringent mode * allow IUPAC codes as isRegularBase alternatives * Add debug output for Fastq record
fnothaft
force-pushed
the
huitseeker-BDGLinting
branch
from
73631a2
to
82838b7
Compare
|
I've just squashed the commits down. |
|
Test PASSed. |
heuermh
added a commit
that referenced
this pull request
Jan 7, 2016
Squashed #907 and ran format-sources
|
Thank you @fnothaft @huitseeker! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the changes from #907 by @huitseeker squashed down to a single commit. After squashing down, I ran
./scripts/format-source, which should resolve the Jenkins failure we're seeing on #907. I'm opening this as a new PR to get @AmplabJenkins to retest it.