Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code style and doc fixes #101

Merged
merged 1 commit into from
Aug 24, 2016
Merged

Conversation

heuermh
Copy link
Member

@heuermh heuermh commented Aug 24, 2016

Fixes #100

Binary incompatible code changes are described by the clirr plugin:

$ mvn clirr:check
...
[INFO] --- clirr-maven-plugin:2.6.1:check (default-cli) @ bdg-formats ---
[INFO] Comparing to version: 0.9.0
[ERROR] 8001: o.b.f.avro.Base: Class org.bdgenomics.formats.avro.Base removed
[ERROR] 6001: o.b.f.avro.Feature: Removed field isCircular
[ERROR] 7002: o.b.f.avro.Feature: Method 'public java.lang.Boolean getIsCircular()' has been removed
[ERROR] 7002: o.b.f.avro.Feature: Method 'public void setIsCircular(java.lang.Boolean)' has been removed
[ERROR] 7002: o.b.f.avro.Feature$Builder: Method 'public org.bdgenomics.formats.avro.Feature$Builder clearIsCircular()' has been removed
[ERROR] 7002: o.b.f.avro.Feature$Builder: Method 'public java.lang.Boolean getIsCircular()' has been removed
[ERROR] 7002: o.b.f.avro.Feature$Builder: Method 'public boolean hasIsCircular()' has been removed
[ERROR] 7002: o.b.f.avro.Feature$Builder: Method 'public org.bdgenomics.formats.avro.Feature$Builder setIsCircular(java.lang.Boolean)' has been removed
[ERROR] 6001: o.b.f.avro.Genotype: Removed field isPhased
[ERROR] 7002: o.b.f.avro.Genotype: Method 'public java.lang.Boolean getIsPhased()' has been removed
[ERROR] 7002: o.b.f.avro.Genotype: Method 'public void setIsPhased(java.lang.Boolean)' has been removed
[ERROR] 7002: o.b.f.avro.Genotype$Builder: Method 'public org.bdgenomics.formats.avro.Genotype$Builder clearIsPhased()' has been removed
[ERROR] 7002: o.b.f.avro.Genotype$Builder: Method 'public java.lang.Boolean getIsPhased()' has been removed
[ERROR] 7002: o.b.f.avro.Genotype$Builder: Method 'public boolean hasIsPhased()' has been removed
[ERROR] 7002: o.b.f.avro.Genotype$Builder: Method 'public org.bdgenomics.formats.avro.Genotype$Builder setIsPhased(java.lang.Boolean)' has been removed
[ERROR] 6001: o.b.f.avro.GenotypeAllele: Removed field Alt
[ERROR] 6001: o.b.f.avro.GenotypeAllele: Removed field NoCall
[ERROR] 6001: o.b.f.avro.GenotypeAllele: Removed field OtherAlt
[ERROR] 6001: o.b.f.avro.GenotypeAllele: Removed field Ref
[ERROR] 6001: o.b.f.avro.Variant: Removed field isSomatic
[ERROR] 7002: o.b.f.avro.Variant: Method 'public java.lang.Boolean getIsSomatic()' has been removed
[ERROR] 7002: o.b.f.avro.Variant: Method 'public void setIsSomatic(java.lang.Boolean)' has been removed
[ERROR] 7002: o.b.f.avro.Variant$Builder: Method 'public org.bdgenomics.formats.avro.Variant$Builder clearIsSomatic()' has been removed
[ERROR] 7002: o.b.f.avro.Variant$Builder: Method 'public java.lang.Boolean getIsSomatic()' has been removed
[ERROR] 7002: o.b.f.avro.Variant$Builder: Method 'public boolean hasIsSomatic()' has been removed
[ERROR] 7002: o.b.f.avro.Variant$Builder: Method 'public org.bdgenomics.formats.avro.Variant$Builder setIsSomatic(java.lang.Boolean)' has been removed

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/bdg-formats-prb/119/
Test PASSed.

@jpdna
Copy link
Member

jpdna commented Aug 24, 2016

+1

@fnothaft
Copy link
Member

LGTM!

@fnothaft fnothaft merged commit 4c8d994 into bigdatagenomics:master Aug 24, 2016
@fnothaft
Copy link
Member

Merged! Thanks @heuermh !

@heuermh
Copy link
Member Author

heuermh commented Aug 24, 2016

Thanks!

@heuermh heuermh deleted the issue-100 branch August 24, 2016 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants