[FORMATS-170] Add sampleId to Feature record #167
Conversation
|
Test PASSed. |
src/main/resources/avro/bdg.avdl
Outdated
| /** | ||
| Identifier for this sample. | ||
| */ | ||
| union { null, string } sampleId = null; |
There was a problem hiding this comment.
@heuermh do you think this should be an Avro Sample or just a string sampleId?
There was a problem hiding this comment.
Elsewhere we use sampleId, with the expectation that users will join on sampleId against metadata samples → Sample.sampleId.
There was a problem hiding this comment.
Thanks @heuermh. Just to clarify then, this is correct?
There was a problem hiding this comment.
Yup. I'd suggest updating the doc string to something like
/**
Sample identifier for this feature. Join with Sample.sampleId for sample metadata.
sampleId tag in GFF3.
*/This matches the style used in #108.
src/main/resources/avro/bdg.avdl
Outdated
| /** | ||
| Identifier for this sample. | ||
| */ | ||
| union { null, string } sampleId = null; |
There was a problem hiding this comment.
Yup. I'd suggest updating the doc string to something like
/**
Sample identifier for this feature. Join with Sample.sampleId for sample metadata.
sampleId tag in GFF3.
*/This matches the style used in #108.
|
Test PASSed. |
|
Propose to milestone version 0.11.4. |
heuermh
changed the title
|
Thank you, @akmorrow13 |
No description provided.