Replaced Contig with ContigName in AlignmentRecord #72
Conversation
|
Test PASSed. |
| @@ -11,7 +11,7 @@ | |||
|
|
|||
| <groupId>org.bdgenomics.bdg-formats</groupId> | |||
| <artifactId>bdg-formats</artifactId> | |||
| <version>0.7.1-SNAPSHOT</version> | |||
| <version>0.7.2-SNAPSHOT</version> | |||
There was a problem hiding this comment.
0.7.1 isn't released yet, is it? Why this version bump?
There was a problem hiding this comment.
ah, I see this was to have [https://github.com/bigdatagenomics/adam/pull/988] depend on a unique version it could use.
might be nice to have a test maven server we could upload builds to using their git SHA as their maven version, as is discussed somewhat here. out of scope here though, so nevermind!
There was a problem hiding this comment.
+1, that's a good suggestion, and probably wouldn't be too hard to implement.
|
LGTM! If no one has an objection, I will merge tomorrow PM. Ping here if you'd like me to hold off on merging to review. |
Related to issue #983 in adam repo
Pulls 'Contig' out of 'AlignmentRecord' for efficiency issues, and replace it with 'ContigName' which is used as an index into the 'SequenceDictionary' which contains the
Contigmetadata details