-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added mango workflow #29
base: master
Are you sure you want to change the base?
Conversation
from toil_lib import require | ||
|
||
# all files must have s3 urls | ||
def is_s3(f): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is_s3
→ is_s3a
, there is a difference
@@ -0,0 +1,15 @@ | |||
# Licensed to Big Data Genomics (BDG) under one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're already in a repo called workflows
, the _pipeline
in the package name is redundant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heuermh do we want to rename all of them then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually, I suppose. This repo hasn't quite fully graduated to bigdatagenomics status yet, with full pull request, review, merge by someone other than yourself, etc. process.
def main(): | ||
|
||
parser = argparse.ArgumentParser() | ||
parser.add_argument('--reference', help='Path to a file containing the S3 URL or local paths to the reference .2bit, fasta, or adam file.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it S3 URL
or S3a URL
?
aws_access_key_id=None, | ||
aws_secret_access_key=None): | ||
""" | ||
Invokes the Mango browsercontainer. Find mango at https://github.com/bigdatagenomics/mango. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
browsercontainer
→ browser container
aws_access_key_id=None, | ||
aws_secret_access_key=None): | ||
""" | ||
Invokes the Mango browsercontainer. Find mango at https://github.com/bigdatagenomics/mango. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
browsercontainer
→ browser container
""" | ||
Functions used across pipelines | ||
|
||
@author Alyssa Morrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I don't believe we use @author
tags ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I guess there are a few left over from toil-lib
No description provided.