Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mango workflow #29

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

akmorrow13
Copy link

No description provided.

@akmorrow13 akmorrow13 changed the title finished mango workflow Added mango workflow Oct 24, 2017
from toil_lib import require

# all files must have s3 urls
def is_s3(f):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is_s3is_s3a, there is a difference

@@ -0,0 +1,15 @@
# Licensed to Big Data Genomics (BDG) under one
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're already in a repo called workflows, the _pipeline in the package name is redundant

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heuermh do we want to rename all of them then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually, I suppose. This repo hasn't quite fully graduated to bigdatagenomics status yet, with full pull request, review, merge by someone other than yourself, etc. process.

def main():

parser = argparse.ArgumentParser()
parser.add_argument('--reference', help='Path to a file containing the S3 URL or local paths to the reference .2bit, fasta, or adam file.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it S3 URL or S3a URL?

aws_access_key_id=None,
aws_secret_access_key=None):
"""
Invokes the Mango browsercontainer. Find mango at https://github.com/bigdatagenomics/mango.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

browsercontainerbrowser container

aws_access_key_id=None,
aws_secret_access_key=None):
"""
Invokes the Mango browsercontainer. Find mango at https://github.com/bigdatagenomics/mango.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

browsercontainerbrowser container

"""
Functions used across pipelines

@author Alyssa Morrow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I don't believe we use @author tags ;)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I guess there are a few left over from toil-lib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants