Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize error handling. #105

Closed
bigeasy opened this issue Jun 18, 2013 · 2 comments
Closed

Finalize error handling. #105

bigeasy opened this issue Jun 18, 2013 · 2 comments
Assignees
@bigeasy
Labels
enhancement
Milestone
Able: Cadence 0.2.0

Comments

@bigeasy
Copy link
Owner

bigeasy commented Jun 18, 2013

You have a lot of notes on error handling. There's no more code to write; time to make some decisions and document them.
@ghost ghost assigned bigeasy Jun 18, 2013
@bigeasy
Copy link
Owner Author

bigeasy commented Jun 23, 2013

My notes are sprawling. Maybe I need to prune them a bit.

@bigeasy
Copy link
Owner Author

bigeasy commented Jun 24, 2013

Issue #59 is also related. Do I assert that callbacks are completed?

bigeasy pushed a commit that referenced this issue Jun 29, 2013
@flatheadmill
Move argument extraction to separate function.
a86341b 
Move argument extraction to a separate function so that we can call
`invoke` directly with arguments, without having to create bogus
`callback` arrays. Necessary to create a more robust implementation of
exceptions and finalizers.

See #111.
See #110.
See #105.

File                             Raw         Min         Zip     Min/Zip
index.js                 13417/13.10  4364/04.26  3715/03.63  1612/01.57
bigeasy pushed a commit that referenced this issue Jun 29, 2013
@flatheadmill
All callbacks return errors array.
ca46d9c 
Within the Cadence implementation, callbacks given to `begin` will
accept an array of errors as their first argument. An empty array
indicates no errors.

See #111.
See #110.
See #105.

File                             Raw         Min         Zip     Min/Zip
index.js                 13300/12.99  4369/04.27  3681/03.59  1608/01.57
bigeasy pushed a commit that referenced this issue Jun 29, 2013
@flatheadmill
Unfold a new cadence just prior to a run
88cd2f1 
See #111.
See #110.
See #105.

File                             Raw         Min         Zip     Min/Zip
index.js                 13407/13.09  4405/04.30  3707/03.62  1614/01.58
bigeasy pushed a commit that referenced this issue Jun 29, 2013
@flatheadmill
Propagate finalizers from a cadence.
1b24383 
Propagate finalizers from a completed cadence to the callback given to
the `begin` function. This allows fixup finalizers the option of merging
the finalizers into the list of finalizers of the calling cadence.

See #111.
See #110.
See #105.

File                             Raw         Min         Zip     Min/Zip
index.js                 13931/13.60  4632/04.52  3788/03.70  1689/01.65
bigeasy pushed a commit that referenced this issue Jun 29, 2013
@flatheadmill
Implemented finalizers.
3b57483 
More tests would be nice, but I'll create separate issues for each
aspect of finalizers I want to test.

Closes #111.
See #110.
See #105.

File                             Raw         Min         Zip     Min/Zip
index.js                 14014/13.69  4636/04.53  3816/03.73  1688/01.65
bigeasy pushed a commit that referenced this issue Jun 29, 2013
@flatheadmill
Test that first error is returned to callback.
9432463 
Closes #114.
See #105.
bigeasy pushed a commit that referenced this issue Jun 29, 2013
@flatheadmill
Implement conditional catch.
a176555 
Closes #110.
See #105.

File                             Raw         Min         Zip     Min/Zip
index.js                 14142/13.81  4648/04.54  3855/03.76  1700/01.66
@bigeasy bigeasy closed this as completed Jun 30, 2013
bigeasy pushed a commit that referenced this issue Jun 30, 2013
@flatheadmill
Finalize error handling.
c4fdddf 
I still need documentation for finalizers, and some finalizer tests, but
I've implemented all of the error machinery, decided how it's all going
to work.

With this commit I've implemented propagation by throwing the `errors`
array and returning the first error unmatched by a conditional catch.

Closes #117.
Closes #116.
Closes #115.
Closes #105.

File                             Raw         Min         Zip     Min/Zip
index.js                 15029/14.68  4518/04.41  4299/04.20  1717/01.68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bigeasy bigeasy

Labels
enhancement
Projects
None yet
Milestone
Able: Cadence 0.2.0
Development

No branches or pull requests
1 participant
@bigeasy