Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw first uncaught exception. #115

Closed
bigeasy opened this issue Jun 30, 2013 · 0 comments
Closed

Throw first uncaught exception. #115

bigeasy opened this issue Jun 30, 2013 · 0 comments
Assignees

Comments

@bigeasy
Copy link
Owner

bigeasy commented Jun 30, 2013

When a conditional catch fails because there are additional errors beyond the caught errors, ensure that the callback gets the first error that did not match the catch block. This will help the application developer. If they've planned on catching a particular error using a conditional catch, but additional errors cause the conditional catch to fail, it will be very confusing when the callback receives, as its only error, an error that matches the catch condition.

@ghost ghost assigned bigeasy Jun 30, 2013
@bigeasy bigeasy closed this as completed Jun 30, 2013
bigeasy pushed a commit that referenced this issue Jun 30, 2013
I still need documentation for finalizers, and some finalizer tests, but
I've implemented all of the error machinery, decided how it's all going
to work.

With this commit I've implemented propagation by throwing the `errors`
array and returning the first error unmatched by a conditional catch.

Closes #117.
Closes #116.
Closes #115.
Closes #105.

File                             Raw         Min         Zip     Min/Zip
index.js                 15029/14.68  4518/04.41  4299/04.20  1717/01.68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant