Merged
Conversation
- Add validation to prevent simultaneous use of conflicting flags - Raise UsageError with clear message when both are specified - Add test coverage for mutual exclusion behavior - Resolves user testing issue #8
- Add PATH search using shutil.which() for browser executables - Supports non-standard install locations (Snap, Flatpak, custom paths) - Falls back to PATH search after configured and known paths - Add comprehensive unit tests for browser detection logic - Update E2E test to mock shutil.which() for failure scenarios - Resolves user testing issue #4 (hard-coded browser paths)
- Move browser executable detection after dry-run check - Use placeholder browser path in dry-run to avoid system checks - Add comprehensive tests for dry-run behavior - Allows testing in environments without browsers installed - Resolves user testing issue #3 (dry-run requires browser)
- Add ValidationStatus class with OK/WARNING/ERROR constants
- Change validate_url() to return 3-tuple (is_valid, status, message)
- Replace fragile string matching ('Warning' in message) with status checks
- Update all callers to use explicit status comparison
- Update all tests for new validation signature
- Resolves user testing issue #9 (fragile validation detection)
- Add platform-specific locking: fcntl (Unix) and msvcrt (Windows) - Make add_app() atomic with single-lock read-check-write operation - Prevent race condition where two simultaneous adds could corrupt registry - Add type annotations to satisfy mypy strict type checking - Resolves user testing issues #6 and #7 (registry concurrency and platform locking)
- Replace placeholder 'yourusername' with actual 'bigr' org name - Update git clone URLs from pwa-forge to pwa_forge (correct repo name) - Add prominent notes that package is not yet on PyPI - Provide alternative installation via pip+git - Update all affected docs: USAGE.md, TROUBLESHOOTING.md, Implementation-specification.md - Resolves user testing issues #1 and #2 (PyPI availability and repo URL)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.