Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket and Server-Side Events live test suite not working #2944

Closed
KianYang-Lee opened this issue Oct 5, 2024 · 4 comments
Closed

WebSocket and Server-Side Events live test suite not working #2944

KianYang-Lee opened this issue Oct 5, 2024 · 4 comments
Labels
documentation Improvements or additions to documentation

Comments

@KianYang-Lee
Copy link
Contributor

After git cloning this repository and following the instructions at https://github.com/bigskysoftware/htmx/blob/master/test/ws-sse/README.md to run node server.mjs, the server does not actually work. The server did launch but when visiting the site locally, it returns this error:

[Error: ENOENT: no such file or directory, open '../../src/ext/ws.js'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: '../../src/ext/ws.js'
}

Upon investigation, there is no such ws.js file in the said directory too. So it could be either misleading README instruction, or the file is indeed missing.

@Telroshan Telroshan added the documentation Improvements or additions to documentation label Oct 5, 2024
@Telroshan
Copy link
Collaborator

Hey, yep that's something we totally forgot and left behind when releasing htmx 2.
Extensions have moved to a separate repository, and this test suite should also go there.
Extensions are now published as their own package, I would expect it to be as simple as replacing the relative import path with the CDN one, but since we didn't run this in a long time, I can't guarantee it isn't obsolete.

If you'd like to investigate & open a PR on the extensions repository to add this test suite in, then another PR on this repo to remove it, please feel free to do so, those would be much welcome!

@KianYang-Lee
Copy link
Contributor Author

Sure will do so @Telroshan

KianYang-Lee added a commit to KianYang-Lee/htmx that referenced this issue Oct 9, 2024
Removes the realtime server for testing WebSockets and Server Sent
Events (SSE) in htmx to the extension repository, as mentioned in issue bigskysoftware#2944.
KianYang-Lee added a commit to KianYang-Lee/htmx that referenced this issue Oct 9, 2024
Removes the realtime server for testing WebSockets and Server Sent
Events (SSE) in htmx to the extension repository, as mentioned in issue bigskysoftware#2944.
Telroshan pushed a commit that referenced this issue Oct 13, 2024
Removes the realtime server for testing WebSockets and Server Sent
Events (SSE) in htmx to the extension repository, as mentioned in issue #2944.
@KianYang-Lee
Copy link
Contributor Author

@Telroshan time to close?

@Telroshan
Copy link
Collaborator

Indeed, ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants