Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old tests from the website #1733

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Remove old tests from the website #1733

merged 1 commit into from
Sep 19, 2023

Conversation

alexpetros
Copy link
Collaborator

@alexpetros alexpetros commented Aug 28, 2023

Description

The website used to host every past test suite, copied into the www directory. We no longer need that on the website (and it makes the codebase impossible to search) so I removed all the old tests and the new tests are hosted simply at /test.

I also replaced the www.js script with a simpler www.sh one (since we no longer need to do anything besides copying, really), which allowed me to remove a node dependency that was only used in that script.

This has the benefit of making the repo 3.5 million (!!) lines of code smaller. It's also part 1 of my plan to better automate our release process.

Testing

Deployed locally and it works. You can still run npm run www to build the test suite, it just uses bash now. Obviously this diff is preposterous but the only parts that matter are www.sh and the package.json, which thankfully github puts at the top.

Little shell one-liner to verify that I didn't change any source files (shows all the modified directories up to two levels):

$ git diff head^ --name-only | awk -F / '{print $1"/"$2}' | sort | uniq -c
   1 package-lock.json/
   1 package.json/
   1 scripts/www.js
   1 scripts/www.sh
5330 www/static

The website used to host every past test suite, copied into the www
directory. We no longer need that on the website (and it makes the
codebase impossible to search) so I removed all the old tests and the
new tests are hosted simply at /test.

I also replaced the www.js script with a simpler www.sh one (since we no
longer need to do anything besides copying, really), which allowed me to
remove a node dependency that was only used in that script.
@alexpetros alexpetros added website Non-documentation website issues ready for review Issues that are ready to be considered for merging labels Aug 28, 2023
@1cg 1cg merged commit d1288d2 into master Sep 19, 2023
@alexpetros alexpetros deleted the remove-old-tests branch September 19, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Issues that are ready to be considered for merging website Non-documentation website issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants