Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues of printing from onboard media #2599

Conversation

kisslorand
Copy link
Contributor

@kisslorand kisslorand commented Sep 8, 2022

Requirements

BTT or MKS TFT

Description

  • when printing from (remote) onboard media and print is cancelled from a remote host (Pronterface, Octoprint, etc) the TFT will show that the print is paused, the progress stays where it was when print was cancelled, apparently the print can pe resumed ("resume" button shows up) but nothing happens (of course it doesn't since the print is already cancelled)
  • a recent Marlin PR (this one) borks up the Pause/Resume procedure/logic when printing from (remote) onboard media rendering it non-functional
  • when printing from (remote) onboard media the layer display type by default might want to display the layer number (if such an option was selected in the "config.ini") which is not possible since it needs the ability to parse comments from the G-code file and onboard media printing has no such capability

Benefits

This PR fixes all of the above:

  • when printing from (remote) onboard media and print is cancelled from a remote host (Pronterface, Octoprint, etc) the TFT handles the cancellation as it should, as it does in all other printing situations
  • the recent Marlin PR changes are adapted, more than that it is backward compatible, it handles Marlin versions with or without the mentioned PR
  • when printing from (remote) onboard media the layer display type defaults to layer height display

This PR also comes with a tiny speed boost for "parseACK()" and some flash size reduction.

Related Issues

No related issues were reported, all these are my own findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants