Bug fixes printing from (remote) onboard media #2692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUGFIXES:
Fixed a bug introduced by Fix some issues of printing from onboard media #2599: The matching rule on parseAck.c became a sink once a print from (remote) onboard is started and remained a sink until the media is changed (e.g. a print from SD card is started). This bug did not allow the parsing of any command (e.g. sent by Terminal or remote host) whose matching rule followed the sink.
Fixed missing M73 parsing when printing from (remote) onboard media reported in Show print screen / progress bar while printing #2631
Furthermore, in case:
SET_PROGRESS_MANUALLYM73_REPORTwere enabled in Marlin, an annoying echo message was displayed on TFT for each received M73 notification and no progress properly displayed.
Updated
README.mdandconfig.inito properly enable M73 notifications towards TFT. Furthermore, all params ordered as by appearance order in Configuration.h and Configuration_adv.hfixes #2599
fixes #2631
PR STATE: Ready for merge