Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow varfish case resubmission #224

Merged
merged 6 commits into from
Feb 8, 2024

Conversation

Nicolai-vKuegelgen
Copy link
Contributor

Previous varfish-cli versions always allowed case resubmission, the new 0.6.2 version does not do this by default, so we need the extra option in cubi-tk.

(I'm not sure why git thinks these other commits are part of this, they are already merged into main as of #222 )

@Nicolai-vKuegelgen Nicolai-vKuegelgen changed the title Feat allow varfish case resubmission feat: allow varfish case resubmission Feb 8, 2024
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb10dbb) 81.04% compared to head (a95a7de) 81.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #224   +/-   ##
=======================================
  Coverage   81.04%   81.05%           
=======================================
  Files         106      106           
  Lines        8211     8212    +1     
=======================================
+ Hits         6655     6656    +1     
  Misses       1556     1556           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sellth
Copy link
Contributor

sellth commented Feb 8, 2024

I can answer the git question right away, because these commits were squashed into cb10dbb. This PR will also be squashed into a new commit, so we're good.

Copy link
Contributor

@sellth sellth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Nicolai-vKuegelgen Nicolai-vKuegelgen merged commit 964bcac into main Feb 8, 2024
6 of 7 checks passed
@Nicolai-vKuegelgen Nicolai-vKuegelgen deleted the feat-allow-varfish-case-resubmission branch February 8, 2024 12:07
This was referenced Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants