Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running install_postgres.sh on Ubuntu!=20.04 breaks apt packages #1061

Closed
mikkonie opened this issue Dec 1, 2022 · 1 comment
Closed

Running install_postgres.sh on Ubuntu!=20.04 breaks apt packages #1061

mikkonie opened this issue Dec 1, 2022 · 1 comment
Labels
bug Something isn't working environment Issues of dependencies, CI, deployment etc.
Milestone
v0.11.1

Comments

@mikkonie
Copy link
Collaborator

mikkonie commented Dec 1, 2022 •
edited
Loading

Something we just learned the hard way :)

The offendling line is the add-apt-repository part, obviously. It can be fixed by editing /etc/apt/sources.list, but this shouldn't happen in the first place.

Even after we do #1060, this remains an issue whenever people don't use the officially supported OS version.

The options are to:

  • Update the script to be Ubuntu version agnostic
  • AND/OR refuse to run the script on an unsupported OS version

Feedback is welcome.
@mikkonie mikkonie added bug Something isn't working environment Issues of dependencies, CI, deployment etc. tbd Comments wanted, spec/schedule/prioritization to be decided, etc. labels Dec 1, 2022
@mikkonie mikkonie modified the milestones: v0.12.0, v0.11.1 Dec 1, 2022
@mikkonie mikkonie removed the tbd Comments wanted, spec/schedule/prioritization to be decided, etc. label Jan 5, 2023
mikkonie added a commit that referenced this issue Jan 5, 2023
@mikkonie
fix minor doc and env issues (#1061, #1064, #1066)
b846acb
@mikkonie
Copy link
Collaborator Author

mikkonie commented Jan 5, 2023

Fixed. We should upgrade to Postgres v12 in the next major release though, see #1074.

@mikkonie mikkonie closed this as completed Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working environment Issues of dependencies, CI, deployment etc.
Projects
None yet
Milestone
v0.11.1
Development

No branches or pull requests
1 participant
@mikkonie