Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate this tool to use Nx Devkit #77

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Migrate this tool to use Nx Devkit #77

merged 1 commit into from
Oct 21, 2021

Conversation

dianjuar
Copy link
Member

@dianjuar dianjuar commented Oct 17, 2021 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: https://www.conventionalcommits.org/en/v1.0.0/
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Both workspaces were tested (Angular and Nx)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Chore
  • Refactoring (no functional changes, no api changes)
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #72

What is the new behavior?

The tool has been refactored to use NxDevKit.

NxDevKit will leverage this tool to have the following benefits:

  • Better Nx integration
  • Elimination of trivial code, now maintained by Nrwl
  • Smooth maintainability (done mainly by Nrwl)
  • Better project structure
  • E2E test support

Does this PR introduce a breaking change?

  • Yes
  • No

The command ngx-deploy-npm:init was replaced by ngx-deploy-npm:install

Other information

close #65
close #38

@dianjuar dianjuar force-pushed the nx-refactor branch 4 times, most recently from eed3ccc to 929149c Compare October 18, 2021 05:08
@dianjuar
Copy link
Member Author

@edbzn it's happening!!! 🎉

@dianjuar dianjuar marked this pull request as draft October 18, 2021 05:10
@dianjuar dianjuar changed the title Nx refactor Migrate this tool to use Nx Devkit Oct 18, 2021
edbzn
edbzn reviewed Oct 19, 2021
View reviewed changes
Copy link

@edbzn edbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments, looks very good overall!

packages/ngx-deploy-npm/src/generators/install/generator.ts Outdated Show resolved Hide resolved
packages/ngx-deploy-npm/src/executors/deploy/engine/engine.spec.ts Outdated Show resolved Hide resolved
packages/ngx-deploy-npm/src/executors/deploy/actions.ts Show resolved Hide resolved
packages/ngx-deploy-npm/src/executors/deploy/executor.ts Outdated Show resolved Hide resolved
packages/ngx-deploy-npm/src/executors/deploy/engine/engine.ts Outdated Show resolved Hide resolved
dianjuar
dianjuar commented Oct 20, 2021
View reviewed changes
workspace.json Outdated Show resolved Hide resolved
@dianjuar dianjuar force-pushed the nx-refactor branch 3 times, most recently from 44e062c to 977c654 Compare October 21, 2021 08:06
@dianjuar
refactor!: migrate to use Nx Devkit
f0f09e3 
BREAKING CHANGE:
For Nx workspaces, the way to install the tool on Nx Workspaces is `nx generate ngx-deploy-npm:install`.  The generator `init` was migrated to `install`
@dianjuar dianjuar marked this pull request as ready for review October 21, 2021 08:13
@dianjuar dianjuar merged commit 57ec334 into master Oct 21, 2021
@dianjuar dianjuar deleted the nx-refactor branch October 21, 2021 08:17
@dianjuar dianjuar restored the nx-refactor branch October 21, 2021 08:18
@dianjuar dianjuar deleted the nx-refactor branch October 21, 2021 08:18
@dianjuar dianjuar mentioned this pull request Nov 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edbzn edbzn edbzn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Impossible to init ngx-deploy-npm in non-Angular NX monorepo Create integration test
2 participants
@dianjuar @edbzn