-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy command fails in an Nx repo #145
Deploy command fails in an Nx repo #145
Comments
Solved it by adding |
However, |
I'm sure that a couple of changes are necessary so that angular-cli-ghpages could also run in a nx workspace. Help would be highly appreciated! |
I'm going to track the wrong default value for |
In my experience, making a schematic run in an Nx Workspace is tricky and hacky. You have constantly made changes (maintenance) to have it running without problems. On the other hand, it is considerably a lot simpler to run an Nx Plugin in an Angular Workspace. What I would suggest to solve this problem is to migrate the project to a NxPlugin. It will be THE refactor, but I believe it is a good thing if we consider the long term. I made that jump on ngx-deploy-npm, and it has paid off. The DX (Development Experience) is at sky levels of satisfaction. Also, allowing the project to not only cover Angular projects but the opportunity to support a lot more technologies is encouraging. |
Some files are autogenerated, but it's still a long path. Here is another project that migrated to be an Nx Plugin with 321 files ngworker/lumberjack#136 |
The most satisfying thing is the ability to reach other technologies with almost no changes. https://github.com/bikecoders/ngx-deploy-npm#supported-library-generators
|
I just remembered that I had to share this. I no longer share the vision of using an Nx Plugin on an Angular Workspace. In January 2024, I dropped support for Angular Workspace on one of my Nx Plugins. To support Nx and Angular workspaces without major problems, you must have two different packages, and from the maintainer's standpoint, it is just too much work. I share more in detail this thought on a blog post
|
Reproduction steps:
npm i angular-cli-ghpages -D && npx nx g angular-cli-ghpages:ng-add
npx nx deploy
Error:
Property 'cname' does not match the schema. 'false' should be a 'string'.
Repo: https://github.com/batbrain9392/ng-media-utils/tree/setup-gh-pages
The text was updated successfully, but these errors were encountered: