Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input capture documentation #203

Merged

Conversation

feschber
Copy link
Contributor

No description provided.

@feschber
Copy link
Contributor Author

#202

@feschber feschber force-pushed the input-capture-documentation branch 2 times, most recently from a5c98e0 to 49b9642 Compare March 25, 2024 16:36
@feschber
Copy link
Contributor Author

FYI: I added the examples over at ashpd-mre to test them.

@feschber feschber force-pushed the input-capture-documentation branch from 49b9642 to 12a7616 Compare March 25, 2024 16:47
@feschber feschber force-pushed the input-capture-documentation branch from 12a7616 to 9c31894 Compare March 25, 2024 16:56
@feschber
Copy link
Contributor Author

I hope it is okay to have reis as a dev-dependency. (otherwise the tests fail)

Copy link
Owner

@bilelmoussaoui bilelmoussaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm, thanks a lot!

src/desktop/input_capture.rs Outdated Show resolved Hide resolved
src/desktop/input_capture.rs Outdated Show resolved Hide resolved
src/desktop/input_capture.rs Outdated Show resolved Hide resolved
src/desktop/input_capture.rs Outdated Show resolved Hide resolved
src/desktop/input_capture.rs Show resolved Hide resolved
@bilelmoussaoui
Copy link
Owner

I hope it is okay to have reis as a dev-dependency. (otherwise the tests fail)

yep, no problem with that :)

feschber and others added 4 commits March 25, 2024 22:31
Co-authored-by: Bilal Elmoussaoui <belmouss@redhat.com>
Co-authored-by: Bilal Elmoussaoui <belmouss@redhat.com>
Co-authored-by: Bilal Elmoussaoui <belmouss@redhat.com>
@feschber
Copy link
Contributor Author

ah and I wanted to ask if I should mention https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/issues/126
since that was a bit frustrating to figure out...

@bilelmoussaoui
Copy link
Owner

ah and I wanted to ask if I should mention https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/issues/126 since that was a bit frustrating to figure out...

that would be nice, while keeping it clear that it only happens with the gnome implementation

@bilelmoussaoui
Copy link
Owner

Thanks a lot!

@bilelmoussaoui bilelmoussaoui merged commit 69f1ecf into bilelmoussaoui:master Mar 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants