Juntian Wei BCO submission.md #176
Conversation
There was a problem hiding this comment.
@jwei2019
I've reviewed your updated BCO and made comments on what further needs to be fixed.
Please make all changes in the BCO editor, download, and update this pull request file with the new JSON (copy/paste- same process as before). Once all changes have been made, assign this pull request back to me and I will review again. Until then, assigning this pull request back to you.
| "orcid": "https://orcid.org/0000-0002-8824-4637", | ||
| "affiliation": "George Washington University", | ||
| "contribution": [ | ||
| "createdBy" |
There was a problem hiding this comment.
Incorrect contribution type. Please modify. See #148
| "contributors": [ | ||
| { | ||
| "name": "", | ||
| "orcid": "", | ||
| "affiliation": "", | ||
| "contribution": [ | ||
| "createdBy" | ||
| ], | ||
| "email": "jwei48@gwmail.gwu.edu" |
There was a problem hiding this comment.
Why is this empty? See #108
| "usability_domain": [ | ||
| "This pipeline is well suited to analyze the small non-coding RNAs obtained from smallRNA-Seq, which enables the future researchers to understand the biological role of sncRNAs better. The pipeline integrates different modules and sources together, and is used to identify different types of sncRNAs, as well as predicting its biological roles and mRNA targets. ", | ||
| "Adapted from: Giurato, Giorgio, Maria Rosaria De Filippo, Antonio Rinaldi, Adnan Hashim, Giovanni Nassa, Maria Ravo, Francesca Rizzo, Roberta Tarallo, and Alessandro Weisz. “IMir: An Integrated Pipeline for High-Throughput Analysis of Small Non-Coding RNA Data Obtained by SmallRNA-Seq.” BMC Bioinformatics 14 (December 13, 2013): 362. https://doi.org/10.1186/1471-2105-14-362.", | ||
| "For all the tools with no version numbers provided, the most up-to-date versions are used. " |
There was a problem hiding this comment.
Great job specifying this. 👍
| "bco_spec_version": "1.3.0", | ||
| "provenance_domain": { | ||
| "name": "iMir: An integrated pipeline for high-throughput analysis of small non-coding RNA data obtained by smallRNA-Seq", | ||
| "version": "1.0.0", |
There was a problem hiding this comment.
good job fixing version.
| "date": "10_16_2019" | ||
| } | ||
| ], | ||
| "contributors": [ |
There was a problem hiding this comment.
Why are the publication authors not added as contributors? See #113
Juntian Wei's final draft of BCO.