remove GCC7 hint #14395
Merged
remove GCC7 hint #14395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yup, we should put in the change about pinging core to get added to the project. Shall I put that in your PR or make a separate one? |
|
CirleCI builds completed without yielding any package artifacts. |
|
Feel free to take this over! |
|
There's a first stab at things, it'd be nice if someone looked it over. I'll mention this in the "Contributing" section of the documentation. |
bgruening
commented
Apr 9, 2019
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| @@ -1,5 +1,5 @@ | |||
| :information_source: | |||
| Bioconda has finished the [GCC7 migration](https://github.com/bioconda/bioconda-recipes/issues/13578). If you are dealing with C/C++ or Python package it can be that you need to rebuild other dependent packages. [Bioconda utils - update-pinning](https://bioconda.github.io/updating.html#updating-recipes-for-a-pinning-change) will assist you with that. If you have any questions please use [issue 13578](https://github.com/bioconda/bioconda-recipes/issues/13578). | |||
| If this is your first pull request to Bioconda please ping @bioconda/core so it can be reviewed and to request being added as a member of the bioconda team. | |||
There was a problem hiding this comment.
I'm wondering if this note will now ping us every time :)
Maybe we should explain what it means to be added to the bioconda-team? We can also link to docs I guess.
There was a problem hiding this comment.
Yeah, I'm not sure if we'll get auto-pinged or not. If so we have to change that. Yes, maybe we should update the docs first.
|
Danke! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bioconda/core I think this note can be removed now?
ℹ️
Bioconda has finished the GCC7 migration. If you are dealing with C/C++ or Python package it can be that you need to rebuild other dependent packages. Bioconda utils - update-pinning will assist you with that. If you have any questions please use issue 13578.