Update docs regarding becoming a new member #497
Conversation
| branch. | ||
|
|
||
| - You want to have other team members make changes directly to your branch | ||
| - You are a bioconda team member. Team members have write access to branches |
There was a problem hiding this comment.
master and bulk if I'm not misleading.
There was a problem hiding this comment.
Hmm, at the moment we're not requiring anything on bulk. Shouldn't we just directly restrict who can merge to it? We can then document that here. We should remove the restriction on admins there as well.
There was a problem hiding this comment.
I've updated the settings on bulk so only admins can merge to it. I think this is what was originally intended (the previous settings had anyone able to merge with no actually required checks!). I'm not sure when those settings got changed, I expect it was an accident...
There was a problem hiding this comment.
Update, people can still merge once tests pass on bulk. They weren't required previously for some reason.
There was a problem hiding this comment.
Mh, not sure why I can't add bioconcda/core to "Restrict who can push to matching branches".
I think core needs to merge to bulk, even if it fails. All others can not merge to bulk [at all | if it passes ]
There was a problem hiding this comment.
I had the same issues. I don't see how to set "no one can merge" except admin. Unless that's what happens if we require tests to pass but then don't select any.
There was a problem hiding this comment.
From reading through the documentation it seems that it's not possible to completely prevent members from merging PRs to bulk if the CI tests pass. That explains how I could sometimes merge things into bulk 6 months ago. I expect that's a risk we'll have to take for the time being. BTW, we should add CODEOWNERS for the CI configuration stuff, just to prevent anyone from accidentally mucking with it. I'll try to make a PR for that today and see if I can use it to prevent any modifications outside of recipes/, to prevent things like the current /multiphate.
There was a problem hiding this comment.
I not afraid people merging passed PRs to bulk, it's as risky as merging passed PRs to master. What is a problem is merging failed into bulk, which should only be allowed for admins.
BTW, we should add CODEOWNERS for the CI configuration stuff, just to prevent anyone from accidentally mucking with it. I'll try to make a PR for that today and see if I can use it to prevent any modifications outside of recipes/, to prevent things like the current /multiphate.
I thought that can be only be used to ping people if certain files are modified. Does it prevent people from modifying files? Can the bot fail linting iff user != bioconda/core and modified-files != recipes/* | blacklist ?
There was a problem hiding this comment.
Codeowners have reviews requested automatically, so yes at least we get notified.
There was a problem hiding this comment.
I'm ditching the CODEOWNERS idea, since there's no way I can find to whitelist the blacklist and I don't want to get spammed every time someone needs to update that.
|
@bgruening Thanks for having a look. I've made some updates, so please look again when you have time. |
|
Haven't gotten around to doing a |
|
@epruesse Makes sense, I'll try to put something together today for everyone to review. |
|
@bgruening If there are no other issues I'll merge this. |
|
Please go ahead. This looks good! |
@bioconda/core Can someone do some sanity checking on this and see if I've missed anything?
Needed for bioconda/bioconda-recipes#14395
Closes bioconda/bioconda-recipes#1